From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH 5/5] PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselves
Date: Sat, 9 Oct 2004 18:56:25 +0200 [thread overview]
Message-ID: <20041009165625.GB21977@postel.suug.ch> (raw)
In-Reply-To: <1097340107.1051.178.camel@jzny.localdomain>
> The action code change is trivial since the dump_stats exists. Located
> in cls_api.c in call to copy_stats.
> My recomendation is to to not even bother using old API since this is
> new code. Go ahead and rip it out and just send TC_STAT2 _only_
> Sorry, dont have the energy to do it right now.
OK, will do, doesn't take too long I guess.
> Youve heard of the TheLinuxWAY(tm) I hope ;-> Otherwise know as
> cutnpaste. One has bug others follow ;->
I know, I was more amazed by how long a slab corruption can exist
without anyone noticing ;)
> BTW, you would be submitting the iproute2 patches as well, correct ?
> i.e you are not just using your tool to do the testing?
Sure, once the kernel part is done. I use iproute2 to check if the
backward compatibility is working and my tool in debug mode printing
out the hierarchy of the TLVs to see if the new stuff is all right.
Adding support to iproute will not take longer than 1-2 hours.
next prev parent reply other threads:[~2004-10-09 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-07 1:01 [PATCH 0/5] PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator Thomas Graf
2004-10-07 1:03 ` [PATCH 1/5] PKT_SCHED: Replace tc_stats with new gnet_stats in struct Qdisc Thomas Graf
2004-10-07 1:04 ` [PATCH 2/5] PKT_SCHED: Use gnet_stats API to copy statistics into netlink message Thomas Graf
2004-10-07 1:05 ` [PATCH 3/5] PKT_SCHED: Introduce gen_replace_estimator Thomas Graf
2004-10-07 1:07 ` [PATCH 4/5] PKT_SCHED: Use generic rate estimator Thomas Graf
2004-10-07 1:08 ` [PATCH 5/5] PKT_SCHED: Qdisc are not supposed to dump TCA_STATS themselves Thomas Graf
2004-10-09 15:48 ` jamal
2004-10-09 16:26 ` Thomas Graf
2004-10-09 16:41 ` jamal
2004-10-09 16:56 ` Thomas Graf [this message]
2004-10-20 1:19 ` [PATCH 0/5] PKT_SCHED: Convert Qdiscs to use generic network statistics/estimator David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041009165625.GB21977@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).