From: David Gibson <hermes@gibson.dropbear.id.au>
To: Jan Dittmer <j.dittmer@portrix.net>
Cc: Cal Peake <cp@absolutedigital.net>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
NetDev Mailing List <netdev@oss.sgi.com>,
proski@gnu.org
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
Date: Mon, 11 Oct 2004 22:32:17 +1000 [thread overview]
Message-ID: <20041011123217.GC28100@zax> (raw)
In-Reply-To: <416A7CB3.9000003@portrix.net>
On Mon, Oct 11, 2004 at 02:29:39PM +0200, Jan Dittmer wrote:
> Cal Peake wrote:
> >On Mon, 11 Oct 2004, Jan Dittmer wrote:
> >
> >
> >>Cal Peake wrote:
> >>
> >>
> >>> inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \
> >>>- readw((hw)->iobase + ( (off) << (hw)->reg_spacing )))
> >>>+ readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing )))
> >>>#define hermes_write_reg(hw, off, val) do { \
> >>
> >>Isn't the correct fix to declare iobase as (void __iomem *) ?
> >
> >
> >iobase is an unsigned long, declaring it as a void pointer is prolly not
> >what we want to do here. The typecast seems proper. A lot of other drivers
> >do this as well thus it must be proper ;-)
>
> Why is iobase a unsigned long in the first place? Isn't this broken for
> 64bit archs?
Um, no.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
next prev parent reply other threads:[~2004-10-11 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 11:34 [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Cal Peake
2004-10-11 11:54 ` Jan Dittmer
2004-10-11 12:04 ` Ricky lloyd
2004-10-11 12:31 ` David Gibson
2004-10-11 12:42 ` Cal Peake
2004-10-11 13:18 ` Borislav Petkov
2004-10-11 13:33 ` viro
2004-10-11 12:23 ` Cal Peake
2004-10-11 12:29 ` Jan Dittmer
2004-10-11 12:32 ` David Gibson [this message]
2004-10-11 12:39 ` Jan Dittmer
2004-10-11 12:49 ` Ben Dooks
2004-10-11 13:16 ` viro
2004-10-11 14:16 ` Cal Peake
2004-10-11 13:12 ` Pavel Roskin
2004-10-11 14:04 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041011123217.GC28100@zax \
--to=hermes@gibson.dropbear.id.au \
--cc=cp@absolutedigital.net \
--cc=j.dittmer@portrix.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).