From: viro@parcelfarce.linux.theplanet.co.uk
To: Borislav Petkov <petkov@uni-muenster.de>
Cc: David Gibson <hermes@gibson.dropbear.id.au>,
Ricky lloyd <ricky.lloyd@gmail.com>,
Jan Dittmer <j.dittmer@portrix.net>,
Cal Peake <cp@absolutedigital.net>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
NetDev Mailing List <netdev@oss.sgi.com>,
proski@gnu.org
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
Date: Mon, 11 Oct 2004 14:33:02 +0100 [thread overview]
Message-ID: <20041011133302.GV23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <200410111518.39001.petkov@uni-muenster.de>
On Mon, Oct 11, 2004 at 03:18:38PM +0200, Borislav Petkov wrote:
> that in a great detail. As a result, the right thing to do here is, I think, to declare all addrs void __iomem*.
> Which leaves a question: while compiling the following code fragment:
>
> <sound/pci/ymfpci/ymfpci_main.c>
> static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset)
> {
> return readb(chip->reg_area_virt + offset);
> }
>
> gcc complains as so:
>
> sound/pci/ymfpci/ymfpci_main.c: In function `snd_ymfpci_readb':
> sound/pci/ymfpci/ymfpci_main.c:57: warning: passing arg 1 of `readb' makes pointer from integer without a cast
>
> Do we have to cast here or use the new interface?
Make ->reg_area_virt void __iomem *. *However*, ALSA folks said that they
have already done iomem annotations in their tree, so that's an area best
left alone until they merge.
next prev parent reply other threads:[~2004-10-11 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 11:34 [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Cal Peake
2004-10-11 11:54 ` Jan Dittmer
2004-10-11 12:04 ` Ricky lloyd
2004-10-11 12:31 ` David Gibson
2004-10-11 12:42 ` Cal Peake
2004-10-11 13:18 ` Borislav Petkov
2004-10-11 13:33 ` viro [this message]
2004-10-11 12:23 ` Cal Peake
2004-10-11 12:29 ` Jan Dittmer
2004-10-11 12:32 ` David Gibson
2004-10-11 12:39 ` Jan Dittmer
2004-10-11 12:49 ` Ben Dooks
2004-10-11 13:16 ` viro
2004-10-11 14:16 ` Cal Peake
2004-10-11 13:12 ` Pavel Roskin
2004-10-11 14:04 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041011133302.GV23987@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=cp@absolutedigital.net \
--cc=hermes@gibson.dropbear.id.au \
--cc=j.dittmer@portrix.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=petkov@uni-muenster.de \
--cc=proski@gnu.org \
--cc=ricky.lloyd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).