From: viro@parcelfarce.linux.theplanet.co.uk
To: Pavel Roskin <proski@gnu.org>
Cc: Cal Peake <cp@absolutedigital.net>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
David Gibson <hermes@gibson.dropbear.id.au>
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
Date: Mon, 11 Oct 2004 15:04:54 +0100 [thread overview]
Message-ID: <20041011140454.GW23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0410110858350.4733@portland.hansa.lan>
On Mon, Oct 11, 2004 at 09:12:03AM -0400, Pavel Roskin wrote:
> Another, more sophisticated solution would be to use union for iobase:
>
> typedef struct hermes {
> union {
> unsigned long io;
> void *mem;
> } base;
> int io_space; /* 1 if we IO-mapped IO, 0 for memory-mapped IO? */
> ...
> }
Not needed. Use ioread*/iowrite* family; it does what you need.
Al, putting together a patchset and documention on that sort of cleanups...
prev parent reply other threads:[~2004-10-11 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 11:34 [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Cal Peake
2004-10-11 11:54 ` Jan Dittmer
2004-10-11 12:04 ` Ricky lloyd
2004-10-11 12:31 ` David Gibson
2004-10-11 12:42 ` Cal Peake
2004-10-11 13:18 ` Borislav Petkov
2004-10-11 13:33 ` viro
2004-10-11 12:23 ` Cal Peake
2004-10-11 12:29 ` Jan Dittmer
2004-10-11 12:32 ` David Gibson
2004-10-11 12:39 ` Jan Dittmer
2004-10-11 12:49 ` Ben Dooks
2004-10-11 13:16 ` viro
2004-10-11 14:16 ` Cal Peake
2004-10-11 13:12 ` Pavel Roskin
2004-10-11 14:04 ` viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041011140454.GW23987@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=cp@absolutedigital.net \
--cc=hermes@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).