From: Christian Borntraeger <linux-kernel@borntraeger.net>
To: Ganesh Venkatesan <ganesh.venkatesan@intel.com>
Cc: "jgarzik@pobox.com" <jgarzik@pobox.com>, netdev <netdev@oss.sgi.com>
Subject: Re: [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures
Date: Fri, 15 Oct 2004 18:46:42 +0200 [thread overview]
Message-ID: <200410151846.42479.linux-kernel@borntraeger.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0410150638490.31227-100000@isotope.jf.intel.com>
Ganesh Venkatesan wrote:
> - rxdr->buffer_info = kmalloc(size, GFP_KERNEL);
[...]
> + rxdr->buffer_info = vmalloc(size);
What is the rationale for this change?
If I recall correctly, Linus opposes the use of vmalloc if there is no real
need.
cheers
Christian
next prev parent reply other threads:[~2004-10-15 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 13:55 [Patch 12/16 2.5] ixgb: replace kmalloc with vmalloc to allocate driver local data structures Ganesh Venkatesan
2004-10-15 16:46 ` Christian Borntraeger [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-15 20:10 Venkatesan, Ganesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410151846.42479.linux-kernel@borntraeger.net \
--to=linux-kernel@borntraeger.net \
--cc=ganesh.venkatesan@intel.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).