From: Jan Killius <jkillius@arcor.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@oss.sgi.com, davem@davemloft.net, jgarzik@pobox.com
Subject: Re: r8169: page allocation failure
Date: Sun, 17 Oct 2004 12:13:04 +0200 [thread overview]
Message-ID: <200410171213.04418.jkillius@arcor.de> (raw)
In-Reply-To: <20041017090837.GA24362@gondor.apana.org.au>
On Sunday 17 October 2004 11:08, Herbert Xu wrote:
> On Sun, Oct 17, 2004 at 05:47:52PM +1000, Herbert Xu wrote:
> > It should instead allocate a new skb of 1 mss. I'll work on it.
>
> In fact it was allocating space that it wasn't even using :)
>
> The following patch makes it allocate skb_headlen(skb) - len instead
> of skb->len - len. When skb is linear there is no difference. When
> it's non-linear we only ever copy the bytes in the header.
>
> Please let me know whether this fixes your problem.
Yes the patch solved the problem completely
>
> Cheers,
--
Jan
next prev parent reply other threads:[~2004-10-17 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-16 18:04 r8169: page allocation failure Jan Killius
2004-10-16 19:08 ` Francois Romieu
[not found] ` <200410162134.22727.jkillius@arcor.de>
[not found] ` <20041016195435.GA21317@electric-eye.fr.zoreil.com>
2004-10-16 20:12 ` Jan Killius
2004-10-16 20:48 ` Francois Romieu
2004-10-16 21:04 ` Jan Killius
2004-10-16 21:23 ` Jan Killius
2004-10-16 21:49 ` Francois Romieu
2004-10-17 7:40 ` Jan Killius
2004-10-17 10:39 ` Francois Romieu
2004-10-17 7:47 ` Herbert Xu
2004-10-17 9:08 ` Herbert Xu
2004-10-17 10:13 ` Jan Killius [this message]
2004-10-20 5:30 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410171213.04418.jkillius@arcor.de \
--to=jkillius@arcor.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).