* Re: [Openswan Users] DPD Problem - message from kernel malformed: unknown address family [not found] <417675C6.3040704@gmx.ch> @ 2004-10-20 22:02 ` Herbert Xu 2004-10-20 23:09 ` Herbert Xu 2004-10-20 23:24 ` Herbert Xu 0 siblings, 2 replies; 5+ messages in thread From: Herbert Xu @ 2004-10-20 22:02 UTC (permalink / raw) To: Eric Marchionni; +Cc: netdev, users, davem Eric Marchionni <mailing-lists@gmx.ch> wrote: > > the ping times out and this occurs in the log: > Oct 20 10:36:11 localhost pluto[12528]: XFRM_MSG_ACQUIRE message from > kernel malformed: unknown address family Looks like nobody has tested shunt routes for a while. It's a kernel bug. We're not setting the family field in the selector. This patch fixes it. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- ===== net/ipv4/xfrm4_state.c 1.10 vs edited ===== --- 1.10/net/ipv4/xfrm4_state.c 2004-08-01 16:28:12 +10:00 +++ edited/net/ipv4/xfrm4_state.c 2004-10-21 07:58:54 +10:00 @@ -18,6 +18,7 @@ struct xfrm_tmpl *tmpl, xfrm_address_t *daddr, xfrm_address_t *saddr) { + x->sel.family = AF_INET; x->sel.daddr.a4 = fl->fl4_dst; x->sel.saddr.a4 = fl->fl4_src; x->sel.dport = fl->fl_ip_dport; @@ -85,11 +86,11 @@ x0->sel.saddr.a4 = saddr->a4; x0->sel.prefixlen_d = 32; x0->sel.prefixlen_s = 32; + x0->sel.family = AF_INET; x0->props.saddr.a4 = saddr->a4; x0->km.state = XFRM_STATE_ACQ; x0->id.daddr.a4 = daddr->a4; x0->id.proto = proto; - x0->props.family = AF_INET; x0->props.mode = mode; x0->props.reqid = reqid; x0->props.family = AF_INET; ===== net/ipv6/xfrm6_state.c 1.12 vs edited ===== --- 1.12/net/ipv6/xfrm6_state.c 2004-08-01 16:28:12 +10:00 +++ edited/net/ipv6/xfrm6_state.c 2004-10-21 07:59:23 +10:00 @@ -25,6 +25,7 @@ { /* Initialize temporary selector matching only * to current session. */ + x->sel.family = AF_INET6; ipv6_addr_copy((struct in6_addr *)&x->sel.daddr, &fl->fl6_dst); ipv6_addr_copy((struct in6_addr *)&x->sel.saddr, &fl->fl6_src); x->sel.dport = fl->fl_ip_dport; @@ -88,6 +89,7 @@ } } if (!x0 && create && (x0 = xfrm_state_alloc()) != NULL) { + x0->sel.family = AF_INET6; ipv6_addr_copy((struct in6_addr *)x0->sel.daddr.a6, (struct in6_addr *)daddr); ipv6_addr_copy((struct in6_addr *)x0->sel.saddr.a6, ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Openswan Users] DPD Problem - message from kernel malformed: unknown address family 2004-10-20 22:02 ` [Openswan Users] DPD Problem - message from kernel malformed: unknown address family Herbert Xu @ 2004-10-20 23:09 ` Herbert Xu 2004-10-20 23:08 ` David S. Miller 2004-10-20 23:24 ` Herbert Xu 1 sibling, 1 reply; 5+ messages in thread From: Herbert Xu @ 2004-10-20 23:09 UTC (permalink / raw) To: Eric Marchionni; +Cc: netdev, users, davem On Thu, Oct 21, 2004 at 08:02:44AM +1000, Herbert Xu wrote: > > Looks like nobody has tested shunt routes for a while. > > It's a kernel bug. We're not setting the family field in the selector. > This patch fixes it. Dave, please scratch that patch. The family is already being set elsewhere. Until we have real cross-family transforms this won't be needed. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Openswan Users] DPD Problem - message from kernel malformed: unknown address family 2004-10-20 23:09 ` Herbert Xu @ 2004-10-20 23:08 ` David S. Miller 2004-10-20 23:15 ` Herbert Xu 0 siblings, 1 reply; 5+ messages in thread From: David S. Miller @ 2004-10-20 23:08 UTC (permalink / raw) To: Herbert Xu; +Cc: mailing-lists, users, netdev On Thu, 21 Oct 2004 09:09:29 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote: > On Thu, Oct 21, 2004 at 08:02:44AM +1000, Herbert Xu wrote: > > > > Looks like nobody has tested shunt routes for a while. > > > > It's a kernel bug. We're not setting the family field in the selector. > > This patch fixes it. > > Dave, please scratch that patch. The family is already being set > elsewhere. Until we have real cross-family transforms this won't > be needed. So why is the unknown address error occuring for this case? Is it just a case we don't need to worry about at this time? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Openswan Users] DPD Problem - message from kernel malformed: unknown address family 2004-10-20 23:08 ` David S. Miller @ 2004-10-20 23:15 ` Herbert Xu 0 siblings, 0 replies; 5+ messages in thread From: Herbert Xu @ 2004-10-20 23:15 UTC (permalink / raw) To: David S. Miller; +Cc: netdev, users On Wed, Oct 20, 2004 at 04:08:49PM -0700, David S. Miller wrote: > > So why is the unknown address error occuring for this case? That's what I'm trying to figure out right now :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Openswan Users] DPD Problem - message from kernel malformed: unknown address family 2004-10-20 22:02 ` [Openswan Users] DPD Problem - message from kernel malformed: unknown address family Herbert Xu 2004-10-20 23:09 ` Herbert Xu @ 2004-10-20 23:24 ` Herbert Xu 1 sibling, 0 replies; 5+ messages in thread From: Herbert Xu @ 2004-10-20 23:24 UTC (permalink / raw) To: Eric Marchionni; +Cc: netdev, users, davem On Thu, Oct 21, 2004 at 08:02:44AM +1000, Herbert Xu wrote: > Eric Marchionni <mailing-lists@gmx.ch> wrote: > > > > the ping times out and this occurs in the log: > > Oct 20 10:36:11 localhost pluto[12528]: XFRM_MSG_ACQUIRE message from > > kernel malformed: unknown address family > > Looks like nobody has tested shunt routes for a while. Alright I just tested it with 2.6.9 with the latest openswan and I can't reproduce this problem. I brought the connection up with auto --route and initiated the connection by a ping packet. Which kernel/openswan are you using? -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-10-20 23:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <417675C6.3040704@gmx.ch>
2004-10-20 22:02 ` [Openswan Users] DPD Problem - message from kernel malformed: unknown address family Herbert Xu
2004-10-20 23:09 ` Herbert Xu
2004-10-20 23:08 ` David S. Miller
2004-10-20 23:15 ` Herbert Xu
2004-10-20 23:24 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).