From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, rlrevell@joe-job.com,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-kernel@gondor.apana.org.au, maxk@qualcomm.com,
irda-users@lists.sourceforge.net, netdev@oss.sgi.com,
alain@parkautomat.net
Subject: Re: [PATCH] Make netif_rx_ni preempt-safe
Date: Wed, 20 Oct 2004 21:58:40 -0700 [thread overview]
Message-ID: <20041020215840.40f0bacc.davem@davemloft.net> (raw)
In-Reply-To: <20041021003503.GA10391@gondor.apana.org.au>
On Thu, 21 Oct 2004 10:35:03 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Wed, Oct 20, 2004 at 05:15:08PM -0700, David S. Miller wrote:
> >
> > +int netif_rx_ni(struct sk_buff *skb)
> > +{
> > + int err = netif_rx(skb);
> > +
> > + preempt_disable();
> > + if (softirq_pending(smp_processor_id()))
> > + do_softirq();
>
> You need to move the netif_rx call inside the disable as otherwise
> you might be checking the pending flag on the wrong CPU.
Good catch, I've made that fix in my tree.
Thanks.
prev parent reply other threads:[~2004-10-21 4:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 23:55 [PATCH] Make netif_rx_ni preempt-safe Lee Revell
2004-10-20 0:00 ` Herbert Xu
2004-10-20 0:22 ` Lee Revell
2004-10-20 15:11 ` Denis Vlasenko
2004-10-20 16:47 ` Lee Revell
2004-10-20 19:14 ` Denis Vlasenko
2004-10-20 19:53 ` Lee Revell
2004-10-20 19:56 ` Denis Vlasenko
2004-10-20 20:25 ` Lee Revell
2004-10-20 20:32 ` Denis Vlasenko
2004-10-21 0:15 ` David S. Miller
2004-10-21 0:35 ` Herbert Xu
2004-10-21 4:58 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020215840.40f0bacc.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=alain@parkautomat.net \
--cc=herbert@gondor.apana.org.au \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=netdev@oss.sgi.com \
--cc=rlrevell@joe-job.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).