From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH] use mmiowb in tg3.c Date: Thu, 21 Oct 2004 16:40:07 -0700 Sender: netdev-bounce@oss.sgi.com Message-ID: <20041021164007.4933b10b.davem@davemloft.net> References: <200410211613.19601.jbarnes@engr.sgi.com> <200410211628.06906.jbarnes@engr.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, netdev@oss.sgi.com, jgarzik@pobox.com, gnb@sgi.com, akepner@sgi.com Return-path: To: Jesse Barnes In-Reply-To: <200410211628.06906.jbarnes@engr.sgi.com> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Thu, 21 Oct 2004 16:28:06 -0700 Jesse Barnes wrote: > This patch originally from Greg Banks. Some parts of the tg3 driver depend on > PIO writes arriving in order. This patch ensures that in two key places > using the new mmiowb macro. This not only prevents bugs (the queues can be > corrupted), but is much faster than ensuring ordering using PIO reads (which > involve a few round trips to the target bus on some platforms). Do other PCI systems which post PIO writes also potentially reorder them just like this SGI system does? Just trying to get this situation straight in my head.