From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kernel@linuxace.com, linux-net@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: 2.6.9 failed assertion in tcp_timer.c
Date: Fri, 22 Oct 2004 15:12:09 -0700 [thread overview]
Message-ID: <20041022151209.26b2d355.davem@davemloft.net> (raw)
In-Reply-To: <20041022215040.GA13309@gondor.apana.org.au>
On Sat, 23 Oct 2004 07:50:40 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Oct 22, 2004 at 11:54:35AM -0700, Phil Oester wrote:
> >
> > This patch gets it a bit further, but still panics (divide by 0?):
>
> Oops, I forgot that this gets called on non-TSO packets as well.
> So we don't really know whether it went further or not :)
>
> We should only set the TSO size if the packet was TSO to start with.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied.
next prev parent reply other threads:[~2004-10-22 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041019215054.GA17565@linuxace.com>
[not found] ` <E1CK3Az-0004P2-00@gondolin.me.apana.org.au>
[not found] ` <20041020164748.GA20905@linuxace.com>
[not found] ` <20041020212651.GA8534@gondor.apana.org.au>
[not found] ` <20041020225536.GA22179@linuxace.com>
[not found] ` <20041021130339.GA19345@gondor.apana.org.au>
[not found] ` <20041021165224.GA25399@linuxace.com>
2004-10-21 21:57 ` 2.6.9 failed assertion in tcp_timer.c Herbert Xu
2004-10-22 5:53 ` David S. Miller
2004-10-22 18:54 ` Phil Oester
2004-10-22 21:50 ` Herbert Xu
2004-10-22 22:12 ` David S. Miller [this message]
2004-10-22 23:24 ` Herbert Xu
2004-10-25 19:58 ` Phil Oester
2004-10-25 20:25 ` David S. Miller
2004-10-26 4:09 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022151209.26b2d355.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@linuxace.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).