From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: laforge@netfilter.org, lmb@suse.de, ahu@ds9a.nl,
hch@infradead.org, netdev@oss.sgi.com
Subject: Re: Allowing netlink_family to be any integer (was: [PATCH 2.6] iptables CLUSTERIP target)
Date: Fri, 22 Oct 2004 16:05:59 -0700 [thread overview]
Message-ID: <20041022160559.28f9c540.davem@davemloft.net> (raw)
In-Reply-To: <E1CKkWZ-0005x5-00@gondolin.me.apana.org.au>
On Fri, 22 Oct 2004 07:31:07 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Initially I considered an interface where kernel users can register
> themselves using a string as the key. But I soon realised that we
> could simply allow the netlink_family field to be an arbitrary integer
> that is used as a key to a hash table.
(I assume you mean "nl_family" not "netlink_family" :-)
> The CPU cost of the hash table isn't too bad since you'll only be
> looking it up when the socket is created.
I'm fine with this idea, however please tell me how you intend
to make things like ->getname() behave?
I would also suggest to start with values > AF_MAX, so that people
sticking other AF_* values in there by accident are caught.
next prev parent reply other threads:[~2004-10-22 23:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 22:38 [PATCH 2.6] iptables CLUSTERIP target Harald Welte
2004-10-20 23:18 ` YOSHIFUJI Hideaki / 吉藤英明
2004-10-21 4:40 ` David S. Miller
2004-10-21 7:44 ` Christoph Hellwig
2004-10-21 7:55 ` Christoph Hellwig
2004-10-21 9:12 ` Harald Welte
2004-10-21 9:40 ` Herbert Xu
2004-10-21 11:05 ` bert hubert
2004-10-21 13:03 ` Harald Welte
2004-10-21 13:33 ` Lars Marowsky-Bree
2004-10-21 14:25 ` Harald Welte
2004-10-21 15:08 ` bert hubert
2004-10-21 21:31 ` Allowing netlink_family to be any integer (was: [PATCH 2.6] iptables CLUSTERIP target) Herbert Xu
2004-10-21 22:53 ` Thomas Graf
2004-10-21 23:02 ` Allowing netlink_family to be any integer Ben Greear
2004-10-22 12:25 ` Allowing netlink_family to be any integer (was: [PATCH 2.6] iptables CLUSTERIP target) Herbert Xu
2004-10-22 12:53 ` jamal
2004-10-22 11:29 ` jamal
2004-10-22 11:39 ` Herbert Xu
2004-10-22 12:19 ` jamal
2004-10-22 12:32 ` Evgeniy Polyakov
2004-10-22 23:05 ` David S. Miller [this message]
2004-10-22 23:16 ` Herbert Xu
2004-10-26 3:27 ` David S. Miller
2004-10-21 16:36 ` [PATCH 2.6] iptables CLUSTERIP target, seq_file version Harald Welte
2004-10-21 17:44 ` jamal
2004-10-21 18:03 ` Harald Welte
2004-10-21 18:41 ` Henrik Nordstrom
2004-10-22 5:52 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022160559.28f9c540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ahu@ds9a.nl \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=laforge@netfilter.org \
--cc=lmb@suse.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).