From: "John W. Linville" <linville@tuxdriver.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: [patch netdev-2.6 3/3] r8169: simplify trick if() expression
Date: Fri, 22 Oct 2004 21:49:24 -0400 [thread overview]
Message-ID: <20041023014923.GB32031@tuxdriver.com> (raw)
In-Reply-To: <20041022202851.GB4216@electric-eye.fr.zoreil.com>
Simplify tricky if() expression in rtl8169_vlan_rx_register().
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
You're probably right -- the "if ((tp->vlgrp = grp))" line is probably
a little TOO clever... :-)
drivers/net/r8169.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
--- ./drivers/net/r8169.c.orig 2004-10-22 21:44:06.050154952 -0400
+++ ./drivers/net/r8169.c 2004-10-22 21:44:26.228087440 -0400
@@ -703,7 +703,8 @@ static void rtl8169_vlan_rx_register(str
unsigned long flags;
spin_lock_irqsave(&tp->lock, flags);
- if ((tp->vlgrp = grp))
+ tp->vlgrp = grp;
+ if (tp->vlgrp)
tp->cp_cmd |= RxVlan;
else
tp->cp_cmd &= ~RxVlan;
next prev parent reply other threads:[~2004-10-23 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 0:57 [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes John W. Linville
2004-10-22 1:00 ` [patch netdev-2.6 1/2] r8169: endian-swap return of rtl8169_tx_vlan_tag() John W. Linville
2004-10-22 1:02 ` [patch netdev-2.6 2/2] r8169: fix RxVlan bit manipulation John W. Linville
2004-10-22 20:28 ` [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes Francois Romieu
2004-10-23 1:49 ` John W. Linville [this message]
2004-10-23 1:51 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041023014923.GB32031@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).