From: "John W. Linville" <linville@tuxdriver.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes
Date: Fri, 22 Oct 2004 21:51:12 -0400 [thread overview]
Message-ID: <20041023015111.GC32031@tuxdriver.com> (raw)
In-Reply-To: <20041022202851.GB4216@electric-eye.fr.zoreil.com>
On Fri, Oct 22, 2004 at 10:28:51PM +0200, Francois Romieu wrote:
> John W. Linville <linville@tuxdriver.com> :
> > Patch 2:
> [nice explanation]
>
> Any objection against me replacing the actual comment of patch #2 (i.e.
> "why" instead of "how") and splitting the "if ((tp->>vlgrp = grp))" over
> two lines ?
Not quite sure which comment you mean, but I'm sure that's fine.
I posted a third patch to fix-up that tricky if() -- you're right,
it is a little TOO clever... :-)
John
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2004-10-23 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 0:57 [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes John W. Linville
2004-10-22 1:00 ` [patch netdev-2.6 1/2] r8169: endian-swap return of rtl8169_tx_vlan_tag() John W. Linville
2004-10-22 1:02 ` [patch netdev-2.6 2/2] r8169: fix RxVlan bit manipulation John W. Linville
2004-10-22 20:28 ` [patch netdev-2.6 0/2] r8169: vlan hwaccel fixes Francois Romieu
2004-10-23 1:49 ` [patch netdev-2.6 3/3] r8169: simplify trick if() expression John W. Linville
2004-10-23 1:51 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041023015111.GC32031@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).