* [PATCH] unexport ei_tx_timeout
@ 2004-10-24 13:12 Christoph Hellwig
2004-10-30 12:37 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-10-24 13:12 UTC (permalink / raw)
To: jgarzik; +Cc: netdev
not used by any module, and the API doesn't make sense as export either
--- 1.24/drivers/net/8390.c 2004-10-20 10:37:15 +02:00
+++ edited/drivers/net/8390.c 2004-10-23 16:17:41 +02:00
@@ -1114,7 +1114,6 @@
#ifdef CONFIG_NET_POLL_CONTROLLER
EXPORT_SYMBOL(ei_poll);
#endif
-EXPORT_SYMBOL(ei_tx_timeout);
EXPORT_SYMBOL(NS8390_init);
EXPORT_SYMBOL(__alloc_ei_netdev);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] unexport ei_tx_timeout
2004-10-24 13:12 [PATCH] unexport ei_tx_timeout Christoph Hellwig
@ 2004-10-30 12:37 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-10-30 12:37 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: netdev
Christoph Hellwig wrote:
> not used by any module, and the API doesn't make sense as export either
next time include a signed-off-by line.
Also, the API _does_ make sense as an export, as it is a generic helper
that can be plugged directly into the netdev->tx_timeout hook.
However, I applied your patch due to the first argument -- no users.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-30 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-24 13:12 [PATCH] unexport ei_tx_timeout Christoph Hellwig
2004-10-30 12:37 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).