* [PATCH] remove bogus exports in ppp
@ 2004-10-24 13:25 Christoph Hellwig
2004-11-16 8:35 ` Christoph Hellwig
2005-01-27 11:22 ` Christoph Hellwig
0 siblings, 2 replies; 10+ messages in thread
From: Christoph Hellwig @ 2004-10-24 13:25 UTC (permalink / raw)
To: paulus; +Cc: netdev
even if they are usefull for debugging they're just bad namespace
pollution for mainline
--- 1.50/drivers/net/ppp_generic.c 2004-08-29 07:49:19 +02:00
+++ edited/drivers/net/ppp_generic.c 2004-10-23 14:08:17 +02:00
@@ -2721,8 +2721,6 @@
EXPORT_SYMBOL(ppp_output_wakeup);
EXPORT_SYMBOL(ppp_register_compressor);
EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
MODULE_ALIAS("/dev/ppp");
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] remove bogus exports in ppp
2004-10-24 13:25 [PATCH] remove bogus exports in ppp Christoph Hellwig
@ 2004-11-16 8:35 ` Christoph Hellwig
2004-11-16 11:45 ` Paul Mackerras
2005-01-27 11:22 ` Christoph Hellwig
1 sibling, 1 reply; 10+ messages in thread
From: Christoph Hellwig @ 2004-11-16 8:35 UTC (permalink / raw)
To: paulus; +Cc: netdev
On Sun, Oct 24, 2004 at 03:25:04PM +0200, Christoph Hellwig wrote:
> even if they are usefull for debugging they're just bad namespace
> pollution for mainline
ping?
--- 1.50/drivers/net/ppp_generic.c 2004-08-29 07:49:19 +02:00
+++ edited/drivers/net/ppp_generic.c 2004-10-23 14:08:17 +02:00
@@ -2721,8 +2721,6 @@
EXPORT_SYMBOL(ppp_output_wakeup);
EXPORT_SYMBOL(ppp_register_compressor);
EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
MODULE_ALIAS("/dev/ppp");
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] remove bogus exports in ppp
2004-11-16 8:35 ` Christoph Hellwig
@ 2004-11-16 11:45 ` Paul Mackerras
0 siblings, 0 replies; 10+ messages in thread
From: Paul Mackerras @ 2004-11-16 11:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: netdev
Christoph Hellwig writes:
> ping?
>
> --- 1.50/drivers/net/ppp_generic.c 2004-08-29 07:49:19 +02:00
> +++ edited/drivers/net/ppp_generic.c 2004-10-23 14:08:17 +02:00
> @@ -2721,8 +2721,6 @@
> EXPORT_SYMBOL(ppp_output_wakeup);
> EXPORT_SYMBOL(ppp_register_compressor);
> EXPORT_SYMBOL(ppp_unregister_compressor);
> -EXPORT_SYMBOL(all_ppp_units); /* for debugging */
> -EXPORT_SYMBOL(all_channels); /* for debugging */
> MODULE_LICENSE("GPL");
> MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
> MODULE_ALIAS("/dev/ppp");
Acked-by: Paul Mackerras <paulus@samba.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] remove bogus exports in ppp
2004-10-24 13:25 [PATCH] remove bogus exports in ppp Christoph Hellwig
2004-11-16 8:35 ` Christoph Hellwig
@ 2005-01-27 11:22 ` Christoph Hellwig
2005-01-27 20:23 ` David S. Miller
1 sibling, 1 reply; 10+ messages in thread
From: Christoph Hellwig @ 2005-01-27 11:22 UTC (permalink / raw)
To: paulus; +Cc: netdev
On Sun, Oct 24, 2004 at 03:25:04PM +0200, Christoph Hellwig wrote:
> even if they are usefull for debugging they're just bad namespace
> pollution for mainline
ping?
Signed-off-by: Christoph Hellwig <hch@lst.de>
--- 1.50/drivers/net/ppp_generic.c 2004-08-29 07:49:19 +02:00
+++ edited/drivers/net/ppp_generic.c 2004-10-23 14:08:17 +02:00
@@ -2721,8 +2721,6 @@
EXPORT_SYMBOL(ppp_output_wakeup);
EXPORT_SYMBOL(ppp_register_compressor);
EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
MODULE_ALIAS("/dev/ppp");
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] remove bogus exports in ppp
2005-01-27 11:22 ` Christoph Hellwig
@ 2005-01-27 20:23 ` David S. Miller
2005-01-27 20:32 ` Christoph Hellwig
0 siblings, 1 reply; 10+ messages in thread
From: David S. Miller @ 2005-01-27 20:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: paulus, netdev
On Thu, 27 Jan 2005 12:22:19 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Sun, Oct 24, 2004 at 03:25:04PM +0200, Christoph Hellwig wrote:
> > even if they are usefull for debugging they're just bad namespace
> > pollution for mainline
>
> ping?
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I've already gotten a light slap on the hand for removing
module exports in 2.6.x, so we might want to skip on this
one.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] remove bogus exports in ppp
2005-01-27 20:23 ` David S. Miller
@ 2005-01-27 20:32 ` Christoph Hellwig
2005-01-27 20:35 ` David S. Miller
0 siblings, 1 reply; 10+ messages in thread
From: Christoph Hellwig @ 2005-01-27 20:32 UTC (permalink / raw)
To: David S. Miller; +Cc: paulus, netdev
On Thu, Jan 27, 2005 at 12:23:57PM -0800, David S. Miller wrote:
> On Thu, 27 Jan 2005 12:22:19 +0100
> Christoph Hellwig <hch@lst.de> wrote:
>
> > On Sun, Oct 24, 2004 at 03:25:04PM +0200, Christoph Hellwig wrote:
> > > even if they are usefull for debugging they're just bad namespace
> > > pollution for mainline
> >
> > ping?
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> I've already gotten a light slap on the hand for removing
> module exports in 2.6.x, so we might want to skip on this
> one.
>From whom?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] remove bogus exports in ppp
@ 2005-01-27 23:32 Paul Mackerras
2005-01-27 23:42 ` David S. Miller
0 siblings, 1 reply; 10+ messages in thread
From: Paul Mackerras @ 2005-01-27 23:32 UTC (permalink / raw)
To: akpm, hch; +Cc: netdev
Remove unnecessary exports from ppp_generic.c.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
diff -urN linux-2.5/drivers/net/ppp_generic.c test/drivers/net/ppp_generic.c
--- linux-2.5/drivers/net/ppp_generic.c 2005-01-27 11:01:23.000000000 +1100
+++ test/drivers/net/ppp_generic.c 2005-01-28 10:23:54.539929344 +1100
@@ -2741,8 +2741,6 @@
EXPORT_SYMBOL(ppp_output_wakeup);
EXPORT_SYMBOL(ppp_register_compressor);
EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
MODULE_LICENSE("GPL");
MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
MODULE_ALIAS("/dev/ppp");
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] remove bogus exports in ppp
2005-01-27 23:32 Paul Mackerras
@ 2005-01-27 23:42 ` David S. Miller
2005-01-28 0:00 ` Paul Mackerras
0 siblings, 1 reply; 10+ messages in thread
From: David S. Miller @ 2005-01-27 23:42 UTC (permalink / raw)
To: Paul Mackerras; +Cc: akpm, hch, netdev
On Fri, 28 Jan 2005 10:32:03 +1100
Paul Mackerras <paulus@samba.org> wrote:
> Remove unnecessary exports from ppp_generic.c.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
How likely is it that anything in the world makes any
reference to this thing outside of the kernel tree?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] remove bogus exports in ppp
2005-01-27 23:42 ` David S. Miller
@ 2005-01-28 0:00 ` Paul Mackerras
0 siblings, 0 replies; 10+ messages in thread
From: Paul Mackerras @ 2005-01-28 0:00 UTC (permalink / raw)
To: David S. Miller; +Cc: akpm, hch, netdev
David S. Miller writes:
> How likely is it that anything in the world makes any
> reference to this thing outside of the kernel tree?
Extremely unlikely. The structures that they refer to are defined in
ppp_generic.c, not a header file, and aren't part of the generic PPP
API. They should never have been exported in fact.
Paul.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2005-01-28 0:00 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-24 13:25 [PATCH] remove bogus exports in ppp Christoph Hellwig
2004-11-16 8:35 ` Christoph Hellwig
2004-11-16 11:45 ` Paul Mackerras
2005-01-27 11:22 ` Christoph Hellwig
2005-01-27 20:23 ` David S. Miller
2005-01-27 20:32 ` Christoph Hellwig
2005-01-27 20:35 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2005-01-27 23:32 Paul Mackerras
2005-01-27 23:42 ` David S. Miller
2005-01-28 0:00 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).