From: "David S. Miller" <davem@davemloft.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jmorris@redhat.com, netdev@oss.sgi.com
Subject: Re: [NET] Give skb_checksum_help an sk_buff * again
Date: Mon, 25 Oct 2004 16:26:06 -0700 [thread overview]
Message-ID: <20041025162606.5938f8df.davem@davemloft.net> (raw)
In-Reply-To: <20041025123507.GA4346@gondor.apana.org.au>
On Mon, 25 Oct 2004 22:35:07 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Since skb_checksum_help has been using pskb_expand_head for a while
> now without any ill effects, I thought it would be a good idea to
> remove the double pointers from it and its callers.
>
> This is what the following patch does. The only "rider" bit is the
> removal of an unnecessary BUG_ON in ip6_pkt_discard_out. The preceding
> assignment was only added because the following function oopsed so
> there is no point in doing BUG_ON.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Looks great, patch applied.
It looks like this makes a few netfilter paths no longer
need a **pskb anymore as well. Folks can feel free to make
that simplification. :-)
Thanks Herbert.
prev parent reply other threads:[~2004-10-25 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 12:35 [NET] Give skb_checksum_help an sk_buff * again Herbert Xu
2004-10-25 23:26 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025162606.5938f8df.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).