From: Herbert Xu <herbert@gondor.apana.org.au>
To: "David S. Miller" <davem@davemloft.net>
Cc: jgarzik@pobox.com, thomas.spatzier@de.ibm.com, netdev@oss.sgi.com
Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
Date: Wed, 27 Oct 2004 11:41:11 +1000 [thread overview]
Message-ID: <20041027014111.GA5548@gondor.apana.org.au> (raw)
In-Reply-To: <20041026170344.262bb3ec.davem@davemloft.net>
On Tue, Oct 26, 2004 at 05:03:44PM -0700, David S. Miller wrote:
>
> Yes and no. SG support requires TX csum support. See the tests we
> make at register_netdev() time.
>
> So as long as you enforce that rule, which I believe you are,
> things are fine.
That's right, the patch will turn off SG whenever TX csum is turned off.
And if you try to turn SG on while TX csum is off, it'll return EINVAL.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2004-10-27 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@de.ibm.com>
[not found] ` <E1CKE5P-0005SP-00@gondolin.me.apana.org.au>
[not found] ` <20041020163510.6d13e9c7.davem@davemloft.net>
2004-10-26 11:19 ` [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used Herbert Xu
2004-10-26 23:51 ` Herbert Xu
2004-10-26 23:54 ` Jeff Garzik
2004-10-27 0:07 ` Herbert Xu
2004-10-27 0:03 ` David S. Miller
2004-10-27 1:41 ` Herbert Xu [this message]
2004-10-27 0:15 ` Jeff Garzik
2004-10-27 0:22 ` Herbert Xu
2004-10-27 0:55 ` David S. Miller
2004-10-28 4:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041027014111.GA5548@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=thomas.spatzier@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).