From: ext Christoph Hellwig <hch@infradead.org>
To: "Teras Timo (EXT-YomiGroup/Helsinki)" <Ext-Timo.Teras@nokia.com>
Cc: ext Christoph Hellwig <hch@infradead.org>,
davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH] Add ability to register class interfaces for network class
Date: Wed, 27 Oct 2004 12:13:17 +0100 [thread overview]
Message-ID: <20041027111317.GA27240@infradead.org> (raw)
In-Reply-To: <20041026205239.GA23825@two.research.nokia.com>
> I pointed out the reason why I need it: to add an attribute:
> /sys/class/net/<interface>/<new_attribute>. Others might want to do this
> too.
>
> Also the interface subsystem is used in many places (eg. i2o) to create
> all the sysfs entries. Maybe it'd be useful to do in net class as well.
> And if'd make separate interfaces for standard attributes and wireless
> attributes. That way you'd get rid of the #ifdefs of WIRELESS_EXT in
> net-sysfs.c.
>
> On the other hand you didn't answer my question: why the
> interface registration should not be possible?
> Documentation/driver-model/interface.txt states that this is exactly the
> thing it should be used for.
Because we don't add interfaces for the sake of it. You still haven't show
the user that wants this. i you presented a sane user the review would be
quite different.
next prev parent reply other threads:[~2004-10-27 11:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 18:35 [PATCH] Add ability to register class interfaces for network class Timo Teräs
2004-10-26 18:48 ` Christoph Hellwig
2004-10-26 20:52 ` Teras Timo (EXT-YomiGroup/Helsinki)
2004-10-27 11:13 ` ext Christoph Hellwig [this message]
2004-10-27 11:31 ` Timo Teräs
2004-10-27 15:59 ` Stephen Hemminger
2004-10-27 18:38 ` Teras Timo (EXT-YomiGroup/Helsinki)
2004-10-27 18:55 ` Stephen Hemminger
2004-10-27 19:20 ` Teras Timo (EXT-YomiGroup/Helsinki)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041027111317.GA27240@infradead.org \
--to=hch@infradead.org \
--cc=Ext-Timo.Teras@nokia.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).