From: "David S. Miller" <davem@davemloft.net>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] 802.1Q VLAN
Date: Wed, 27 Oct 2004 21:42:57 -0700 [thread overview]
Message-ID: <20041027214257.24637a9f.davem@davemloft.net> (raw)
In-Reply-To: <41804B35.1080306@candelatech.com>
On Wed, 27 Oct 2004 18:28:21 -0700
Ben Greear <greearb@candelatech.com> wrote:
> > Also, what is up with the magic "23" constant in the get realdev
> > name function strncpy() call?
>
> Well, the fields are 24-bytes long, as defined in the include/linux/if_vlan.h
> file. I could change it to a #define and/or use sizeof if you prefer.
You could also use "sizeof(obj->member)".
next prev parent reply other threads:[~2004-10-28 4:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 21:07 [PATCH] 802.1Q VLAN Ben Greear
2004-10-22 21:46 ` Francois Romieu
2004-10-22 22:09 ` Ben Greear
2004-10-23 0:24 ` Francois Romieu
2004-10-25 20:51 ` Ben Greear
2004-10-25 23:56 ` Ben Greear
2004-10-27 1:02 ` David S. Miller
2004-10-27 23:49 ` David S. Miller
2004-10-28 1:28 ` Ben Greear
2004-10-28 4:42 ` David S. Miller [this message]
2004-10-28 23:40 ` Tommy Christensen
2004-10-28 23:35 ` David S. Miller
2004-10-29 0:23 ` Ben Greear
2004-10-29 0:38 ` Krzysztof Halasa
2004-10-29 8:29 ` Tommy Christensen
2004-10-29 17:45 ` Ben Greear
2004-10-29 23:37 ` Tommy Christensen
2004-10-29 23:56 ` Ben Greear
2004-10-30 0:05 ` Ben Greear
2004-10-30 0:31 ` Tommy Christensen
2004-11-01 18:58 ` Ben Greear
2004-11-01 23:08 ` Tommy Christensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041027214257.24637a9f.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).