* [XFRM] Don't panic in xfrm_user_init
@ 2004-10-28 3:16 Herbert Xu
2004-10-28 4:46 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2004-10-28 3:16 UTC (permalink / raw)
To: David S. Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
Hi:
Since xfrm_user can be built as a module it's best not to panic
when something goes wrong in xfrm_user_init. Call me a wimp for
not fixing netlink_kernel_init's return value :)
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 394 bytes --]
===== net/xfrm/xfrm_user.c 1.48 vs edited =====
--- 1.48/net/xfrm/xfrm_user.c 2004-09-11 07:35:53 +10:00
+++ edited/net/xfrm/xfrm_user.c 2004-10-28 13:13:01 +10:00
@@ -1232,8 +1232,7 @@
xfrm_nl = netlink_kernel_create(NETLINK_XFRM, xfrm_netlink_rcv);
if (xfrm_nl == NULL)
- panic("xfrm_user_init: cannot initialize xfrm_nl\n");
-
+ return -ENOMEM;
xfrm_register_km(&netlink_mgr);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [XFRM] Don't panic in xfrm_user_init
2004-10-28 3:16 [XFRM] Don't panic in xfrm_user_init Herbert Xu
@ 2004-10-28 4:46 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-10-28 4:46 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
On Thu, 28 Oct 2004 13:16:40 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Since xfrm_user can be built as a module it's best not to panic
> when something goes wrong in xfrm_user_init. Call me a wimp for
> not fixing netlink_kernel_init's return value :)
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks Herbert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-28 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-28 3:16 [XFRM] Don't panic in xfrm_user_init Herbert Xu
2004-10-28 4:46 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).