From: Christoph Hellwig <hch@infradead.org>
To: akpm@osdl.org
Cc: davem@redhat.com, jgarzik@pobox.com, netdev@oss.sgi.com,
pluto@pld-linux.org
Subject: Re: [patch 8/9] AES: allow modular build
Date: Thu, 28 Oct 2004 10:04:31 +0100 [thread overview]
Message-ID: <20041028090431.GA8193@infradead.org> (raw)
In-Reply-To: <200410280721.i9S7Lk908015@mail.osdl.org>
On Thu, Oct 28, 2004 at 12:19:47AM -0700, akpm@osdl.org wrote:
>
> From: <pluto@pld-linux.org>
>
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> 25-akpm/arch/i386/crypto/Makefile | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/i386/crypto/Makefile~aes-allow-modular-build arch/i386/crypto/Makefile
> --- 25/arch/i386/crypto/Makefile~aes-allow-modular-build 2004-10-28 00:17:08.598496816 -0700
> +++ 25-akpm/arch/i386/crypto/Makefile 2004-10-28 00:17:08.603496056 -0700
> @@ -6,4 +6,4 @@
>
> obj-$(CONFIG_CRYPTO_AES_586) += aes-i586.o
>
> -aes-i586-y := aes-i586-asm.o aes.o
> +aes-i586-objs := aes-i586-asm.o aes.o
This doesn't make any sense to me.
foo-objs and foo-y are treated equivalent by the build system, and not
related to modular builds at all. In fact -y is preffered these days
as it allows to build parts of the multi-object module conditionally using
expressions like:
foo-y += foo_main.o
foo-$(CONFIG_FOO_BAR) += foo_bar.o
next prev parent reply other threads:[~2004-10-28 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 7:19 [patch 8/9] AES: allow modular build akpm
2004-10-28 9:04 ` Christoph Hellwig [this message]
2004-10-28 16:57 ` Paweł Sikora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028090431.GA8193@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=pluto@pld-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).