From: "David S. Miller" <davem@redhat.com>
To: akpm@osdl.org
Cc: jgarzik@pobox.com, netdev@oss.sgi.com, akpm@osdl.org, simlo@phys.au.dk
Subject: Re: [patch 1/9] arcnet fixes
Date: Thu, 28 Oct 2004 16:41:11 -0700 [thread overview]
Message-ID: <20041028164111.5ffaca70.davem@redhat.com> (raw)
In-Reply-To: <200410280721.i9S7Lb907978@mail.osdl.org>
On Thu, 28 Oct 2004 00:19:38 -0700
akpm@osdl.org wrote:
I don't know what to do with this kind of thing.
Jeff, what do you think? Do we have anyone in any
way active with Arcnet other than this guy?
One problem with the patch though.
> diff -puN include/linux/if_ether.h~arcnet-fixes include/linux/if_ether.h
> --- 25/include/linux/if_ether.h~arcnet-fixes 2004-10-28 00:17:07.230704752 -0700
> +++ 25-akpm/include/linux/if_ether.h 2004-10-28 00:17:07.247702168 -0700
> @@ -91,6 +91,7 @@
> #define ETH_P_IRDA 0x0017 /* Linux-IrDA */
> #define ETH_P_ECONET 0x0018 /* Acorn Econet */
> #define ETH_P_HDLC 0x0019 /* HDLC frames */
> +#define ETH_P_ARCNET 0x0020 /* ArcNet */
You should use 0x001a or similar, so you don't have
to do this next part of your patch, bumping NPROTO
in net.h
> diff -puN include/linux/net.h~arcnet-fixes include/linux/net.h
> --- 25/include/linux/net.h~arcnet-fixes 2004-10-28 00:17:07.232704448 -0700
> +++ 25-akpm/include/linux/net.h 2004-10-28 00:17:07.248702016 -0700
> @@ -26,7 +26,7 @@
> struct poll_table_struct;
> struct inode;
>
> -#define NPROTO 32 /* should be enough for now.. */
> +#define NPROTO 33 /* should be enough for now.. */
>
> #define SYS_SOCKET 1 /* sys_socket(2) */
> #define SYS_BIND 2 /* sys_bind(2) */
next prev parent reply other threads:[~2004-10-28 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 7:19 [patch 1/9] arcnet fixes akpm
2004-10-28 23:41 ` David S. Miller [this message]
2004-10-29 14:46 ` Esben Nielsen
2004-10-29 20:39 ` Andrew Morton
2004-11-06 20:14 ` Esben Nielsen
2004-11-06 21:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028164111.5ffaca70.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=simlo@phys.au.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).