* [patch 8/9] AES: allow modular build
@ 2004-10-28 7:19 akpm
2004-10-28 9:04 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: akpm @ 2004-10-28 7:19 UTC (permalink / raw)
To: davem; +Cc: jgarzik, netdev, akpm, pluto
From: <pluto@pld-linux.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/arch/i386/crypto/Makefile | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/i386/crypto/Makefile~aes-allow-modular-build arch/i386/crypto/Makefile
--- 25/arch/i386/crypto/Makefile~aes-allow-modular-build 2004-10-28 00:17:08.598496816 -0700
+++ 25-akpm/arch/i386/crypto/Makefile 2004-10-28 00:17:08.603496056 -0700
@@ -6,4 +6,4 @@
obj-$(CONFIG_CRYPTO_AES_586) += aes-i586.o
-aes-i586-y := aes-i586-asm.o aes.o
+aes-i586-objs := aes-i586-asm.o aes.o
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 8/9] AES: allow modular build
2004-10-28 7:19 [patch 8/9] AES: allow modular build akpm
@ 2004-10-28 9:04 ` Christoph Hellwig
2004-10-28 16:57 ` Paweł Sikora
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-10-28 9:04 UTC (permalink / raw)
To: akpm; +Cc: davem, jgarzik, netdev, pluto
On Thu, Oct 28, 2004 at 12:19:47AM -0700, akpm@osdl.org wrote:
>
> From: <pluto@pld-linux.org>
>
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> 25-akpm/arch/i386/crypto/Makefile | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/i386/crypto/Makefile~aes-allow-modular-build arch/i386/crypto/Makefile
> --- 25/arch/i386/crypto/Makefile~aes-allow-modular-build 2004-10-28 00:17:08.598496816 -0700
> +++ 25-akpm/arch/i386/crypto/Makefile 2004-10-28 00:17:08.603496056 -0700
> @@ -6,4 +6,4 @@
>
> obj-$(CONFIG_CRYPTO_AES_586) += aes-i586.o
>
> -aes-i586-y := aes-i586-asm.o aes.o
> +aes-i586-objs := aes-i586-asm.o aes.o
This doesn't make any sense to me.
foo-objs and foo-y are treated equivalent by the build system, and not
related to modular builds at all. In fact -y is preffered these days
as it allows to build parts of the multi-object module conditionally using
expressions like:
foo-y += foo_main.o
foo-$(CONFIG_FOO_BAR) += foo_bar.o
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 8/9] AES: allow modular build
2004-10-28 9:04 ` Christoph Hellwig
@ 2004-10-28 16:57 ` Paweł Sikora
0 siblings, 0 replies; 3+ messages in thread
From: Paweł Sikora @ 2004-10-28 16:57 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, davem, jgarzik, netdev
On Thursday 28 of October 2004 11:04, Christoph Hellwig wrote:
> On Thu, Oct 28, 2004 at 12:19:47AM -0700, akpm@osdl.org wrote:
> > From: <pluto@pld-linux.org>
> >
> >
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > ---
> >
> > 25-akpm/arch/i386/crypto/Makefile | 2 +-
> > 1 files changed, 1 insertion(+), 1 deletion(-)
> >
> > diff -puN arch/i386/crypto/Makefile~aes-allow-modular-build
> > arch/i386/crypto/Makefile ---
> > 25/arch/i386/crypto/Makefile~aes-allow-modular-build 2004-10-28
> > 00:17:08.598496816 -0700 +++ 25-akpm/arch/i386/crypto/Makefile 2004-10-28
> > 00:17:08.603496056 -0700 @@ -6,4 +6,4 @@
> >
> > obj-$(CONFIG_CRYPTO_AES_586) += aes-i586.o
> >
> > -aes-i586-y := aes-i586-asm.o aes.o
> > +aes-i586-objs := aes-i586-asm.o aes.o
>
> This doesn't make any sense to me.
> foo-objs and foo-y are treated equivalent by the build system, and not
> related to modular builds at all. In fact -y is preffered these days
> as it allows to build parts of the multi-object module conditionally using
> expressions like:
>
> foo-y += foo_main.o
> foo-$(CONFIG_FOO_BAR) += foo_bar.o
Hmm,
Without my fix the 2.6.8rc[34] produced unresolved symbol
in the AES module. With this fix the problem didn't exist.
Now (2.6.10rc1) it works fine without this fix.
Where was the problem? [1] -y/-objs | [2] AES module.
--
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */
#define say(x) lie(x)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-28 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-28 7:19 [patch 8/9] AES: allow modular build akpm
2004-10-28 9:04 ` Christoph Hellwig
2004-10-28 16:57 ` Paweł Sikora
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).