* [2.6 patch] appletalk: remove an unused function
@ 2004-10-28 22:10 Adrian Bunk
2004-10-28 23:26 ` David S. Miller
2004-10-29 0:14 ` Adrian Bunk
0 siblings, 2 replies; 6+ messages in thread
From: Adrian Bunk @ 2004-10-28 22:10 UTC (permalink / raw)
To: acme; +Cc: davem, netdev, linux-kernel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The patch below removes an unsed function from net/appletalk/ddp.c
diffstat output:
net/appletalk/ddp.c | 7 -------
1 files changed, 7 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
- --- linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c.old 2004-10-28 23:49:44.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c 2004-10-28 23:49:57.000000000 +0200
@@ -78,13 +78,6 @@
sk_add_node(sk, &atalk_sockets);
}
- -static inline void atalk_insert_socket(struct sock *sk)
- -{
- - write_lock_bh(&atalk_sockets_lock);
- - __atalk_insert_socket(sk);
- - write_unlock_bh(&atalk_sockets_lock);
- -}
- -
static inline void atalk_remove_socket(struct sock *sk)
{
write_lock_bh(&atalk_sockets_lock);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFBgW5mmfzqmE8StAARAvaMAJ94zqUtcUYZKMtwHKnTtKof9ew9pACeJIoT
d7KwwwKipvnGxnCmnwf8U0E=
=xXRj
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] appletalk: remove an unused function
2004-10-28 22:10 [2.6 patch] appletalk: remove an unused function Adrian Bunk
@ 2004-10-28 23:26 ` David S. Miller
2004-10-28 23:41 ` Jeff Garzik
2004-10-29 2:56 ` Miles Bader
2004-10-29 0:14 ` Adrian Bunk
1 sibling, 2 replies; 6+ messages in thread
From: David S. Miller @ 2004-10-28 23:26 UTC (permalink / raw)
To: Adrian Bunk; +Cc: acme, netdev, linux-kernel
On Fri, 29 Oct 2004 00:10:46 +0200
Adrian Bunk <bunk@stusta.de> wrote:
> - -static inline void atalk_insert_socket(struct sock *sk)
> - -{
> - - write_lock_bh(&atalk_sockets_lock);
> - - __atalk_insert_socket(sk);
> - - write_unlock_bh(&atalk_sockets_lock);
> - -}
> - -
This is a patch of a patch, I doubt it will apply cleanly ;-)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] appletalk: remove an unused function
2004-10-28 23:26 ` David S. Miller
@ 2004-10-28 23:41 ` Jeff Garzik
2004-10-29 2:56 ` Miles Bader
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2004-10-28 23:41 UTC (permalink / raw)
To: David S. Miller; +Cc: Adrian Bunk, acme, netdev, linux-kernel
On Thu, Oct 28, 2004 at 04:26:43PM -0700, David S. Miller wrote:
> On Fri, 29 Oct 2004 00:10:46 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > - -static inline void atalk_insert_socket(struct sock *sk)
> > - -{
> > - - write_lock_bh(&atalk_sockets_lock);
> > - - __atalk_insert_socket(sk);
> > - - write_unlock_bh(&atalk_sockets_lock);
> > - -}
> > - -
>
> This is a patch of a patch, I doubt it will apply cleanly ;-)
Ditto, all the patches sent to me look like this, too.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] appletalk: remove an unused function
2004-10-28 23:26 ` David S. Miller
2004-10-28 23:41 ` Jeff Garzik
@ 2004-10-29 2:56 ` Miles Bader
1 sibling, 0 replies; 6+ messages in thread
From: Miles Bader @ 2004-10-29 2:56 UTC (permalink / raw)
To: David S. Miller; +Cc: Adrian Bunk, acme, netdev, linux-kernel
"David S. Miller" <davem@davemloft.net> writes:
> This is a patch of a patch, I doubt it will apply cleanly ;-)
Note if you run it through gpg/pgp decoding it will output the real
patch (my mail client does this automatically, so the comments saying
the patches were screwed up were very confusing at first!).
-Miles
--
Run away! Run away!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] appletalk: remove an unused function
2004-10-28 22:10 [2.6 patch] appletalk: remove an unused function Adrian Bunk
2004-10-28 23:26 ` David S. Miller
@ 2004-10-29 0:14 ` Adrian Bunk
2004-11-02 0:28 ` David S. Miller
1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2004-10-29 0:14 UTC (permalink / raw)
To: acme; +Cc: davem, netdev, linux-kernel
[ this time without the problems due to a digital signature... ]
The patch below removes an unsed function from net/appletalk/ddp.c
diffstat output:
net/appletalk/ddp.c | 7 -------
1 files changed, 7 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c.old 2004-10-28 23:49:44.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c 2004-10-28 23:49:57.000000000 +0200
@@ -78,13 +78,6 @@
sk_add_node(sk, &atalk_sockets);
}
-static inline void atalk_insert_socket(struct sock *sk)
-{
- write_lock_bh(&atalk_sockets_lock);
- __atalk_insert_socket(sk);
- write_unlock_bh(&atalk_sockets_lock);
-}
-
static inline void atalk_remove_socket(struct sock *sk)
{
write_lock_bh(&atalk_sockets_lock);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-11-02 0:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-28 22:10 [2.6 patch] appletalk: remove an unused function Adrian Bunk
2004-10-28 23:26 ` David S. Miller
2004-10-28 23:41 ` Jeff Garzik
2004-10-29 2:56 ` Miles Bader
2004-10-29 0:14 ` Adrian Bunk
2004-11-02 0:28 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).