* [PATCH 2.4] PKT_SCHED: break is not enough to stop walking
@ 2004-10-29 0:29 Thomas Graf
2004-11-02 0:58 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2004-10-29 0:29 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
break is not enough to escape from the walking loops, since
multiple encapsulated loops are used to traverse the hash tables.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
--- linux-2.4.28-rc1-bk1.orig/net/sched/cls_fw.c 2004-10-29 01:34:19.000000000 +0200
+++ linux-2.4.28-rc1-bk1/net/sched/cls_fw.c 2004-10-29 01:36:19.000000000 +0200
@@ -292,7 +292,7 @@
}
if (arg->fn(tp, (unsigned long)f, arg) < 0) {
arg->stop = 1;
- break;
+ return;
}
arg->count++;
}
--- linux-2.4.28-rc1-bk1.orig/net/sched/cls_route.c 2004-10-29 01:34:19.000000000 +0200
+++ linux-2.4.28-rc1-bk1/net/sched/cls_route.c 2004-10-29 01:36:31.000000000 +0200
@@ -541,7 +541,7 @@
}
if (arg->fn(tp, (unsigned long)f, arg) < 0) {
arg->stop = 1;
- break;
+ return;
}
arg->count++;
}
--- linux-2.4.28-rc1-bk1.orig/net/sched/cls_rsvp.h 2004-10-29 01:34:19.000000000 +0200
+++ linux-2.4.28-rc1-bk1/net/sched/cls_rsvp.h 2004-10-29 01:55:09.000000000 +0200
@@ -604,7 +604,7 @@
}
if (arg->fn(tp, (unsigned long)f, arg) < 0) {
arg->stop = 1;
- break;
+ return;
}
arg->count++;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.4] PKT_SCHED: break is not enough to stop walking
2004-10-29 0:29 [PATCH 2.4] PKT_SCHED: break is not enough to stop walking Thomas Graf
@ 2004-11-02 0:58 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-11-02 0:58 UTC (permalink / raw)
To: Thomas Graf; +Cc: netdev
On Fri, 29 Oct 2004 02:29:58 +0200
Thomas Graf <tgraf@suug.ch> wrote:
> break is not enough to escape from the walking loops, since
> multiple encapsulated loops are used to traverse the hash tables.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks for doing this backport Thomas.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-02 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-29 0:29 [PATCH 2.4] PKT_SCHED: break is not enough to stop walking Thomas Graf
2004-11-02 0:58 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).