From: Andrew Morton <akpm@osdl.org>
To: Esben Nielsen <simlo@phys.au.dk>
Cc: davem@redhat.com, jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [patch 1/9] arcnet fixes
Date: Fri, 29 Oct 2004 13:39:23 -0700 [thread overview]
Message-ID: <20041029133923.66dd719f.akpm@osdl.org> (raw)
In-Reply-To: <Pine.OSF.4.05.10410291603000.5037-100000@da410.ifa.au.dk>
Esben Nielsen <simlo@phys.au.dk> wrote:
>
> > One problem with the patch though.
> >
> > > diff -puN include/linux/if_ether.h~arcnet-fixes include/linux/if_ether.h
> > > --- 25/include/linux/if_ether.h~arcnet-fixes 2004-10-28 00:17:07.230704752 -0700
> > > +++ 25-akpm/include/linux/if_ether.h 2004-10-28 00:17:07.247702168 -0700
> > > @@ -91,6 +91,7 @@
> > > #define ETH_P_IRDA 0x0017 /* Linux-IrDA */
> > > #define ETH_P_ECONET 0x0018 /* Acorn Econet */
> > > #define ETH_P_HDLC 0x0019 /* HDLC frames */
> > > +#define ETH_P_ARCNET 0x0020 /* ArcNet */
> >
> > You should use 0x001a or similar, so you don't have
> > to do this next part of your patch, bumping NPROTO
> > in net.h
> >
>
> Doh! I can't count in hex it seems. This would probably also mean I won't
> have to recompile the whole kernel but just the modules and I don't have
> to reboot to make it work on a new machine - but just until somebody else
> picks the same protocol number ofcourse.
>
> Do I have to fix the problem and resubmit?
Yes please. A patch relative to the previous one would be nice.
next prev parent reply other threads:[~2004-10-29 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 7:19 [patch 1/9] arcnet fixes akpm
2004-10-28 23:41 ` David S. Miller
2004-10-29 14:46 ` Esben Nielsen
2004-10-29 20:39 ` Andrew Morton [this message]
2004-11-06 20:14 ` Esben Nielsen
2004-11-06 21:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029133923.66dd719f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=simlo@phys.au.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).