From: "David S. Miller" <davem@davemloft.net>
To: Mike Waychison <Michael.Waychison@Sun.COM>
Cc: Brian.Somers@Sun.COM, netdev@oss.sgi.com
Subject: Re: [PATCH] TG3: fiber hw autoneg bounces
Date: Mon, 1 Nov 2004 17:27:12 -0800 [thread overview]
Message-ID: <20041101172712.55e97846.davem@davemloft.net> (raw)
In-Reply-To: <4182B6A7.90700@sun.com>
On Fri, 29 Oct 2004 17:31:19 -0400
Mike Waychison <Michael.Waychison@Sun.COM> wrote:
> I've traced it to be caused by the tg3_timer 1 second work noticing that
> MAC_STATUS_LNKSTATE_CHANGED was set, which driver would see as the link
> going down.
>
> Upon further inspection, it appears that we don't wait long enough
> between setting SG_DIG_CTRL and reading the SG_DIG_STATUS for the result.
How come the bcm5700 Broadcom driver gets away without this
incredibly huge delay? The touching of the device is absolutely
identical in the tg3 driver to what Broadcom's bcm5700 code
is doing.
I'll apply the patch for now though...
prev parent reply other threads:[~2004-11-02 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 21:31 [PATCH] TG3: fiber hw autoneg bounces Mike Waychison
2004-11-02 1:27 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101172712.55e97846.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Brian.Somers@Sun.COM \
--cc=Michael.Waychison@Sun.COM \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).