From: Matt Domsch <Matt_Domsch@dell.com>
To: jamal <hadi@cyberus.ca>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
Date: Mon, 1 Nov 2004 15:59:44 -0600 [thread overview]
Message-ID: <20041101215944.GB17279@lists.us.dell.com> (raw)
In-Reply-To: <1099345849.1073.1.camel@jzny.localdomain>
On Mon, Nov 01, 2004 at 04:50:49PM -0500, jamal wrote:
> My onluy comment is on use of -EOVERFLOW which i have seen only
> being used in the context of floating point computation
> (same as -EUNDERFLOW). I dont know what the right thing to return would
> be.
Actually, -EOVERFLOW appears throughout the kernel. A couple examples:
drivers/net/ppp_generic.:ppp_read() uses it to indicate skb->len >
sizeof buffer to put the data into.
fs/stat.c:cp_new_stat() and friends
if (stat->size > MAX_NON_LFS)
return -EOVERFLOW;
indicates that the file size is larger than can be represented by the app.
I believe our use would be consistent.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2004-11-01 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 21:51 [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len Matt Domsch
2004-10-30 1:37 ` Matt Domsch
2004-10-30 1:51 ` Herbert Xu
2004-10-30 3:09 ` Matt Domsch
2004-10-30 19:10 ` jamal
2004-11-01 4:44 ` Matt Domsch
2004-11-01 17:34 ` Matt Domsch
2004-11-01 20:27 ` Herbert Xu
2004-11-01 20:38 ` Matt Domsch
2004-11-01 20:41 ` Herbert Xu
2004-11-01 20:45 ` Matt Domsch
2004-11-01 21:50 ` jamal
2004-11-01 21:59 ` Matt Domsch [this message]
2004-11-01 22:06 ` Herbert Xu
2004-11-04 0:07 ` David S. Miller
2004-11-04 3:42 ` Matt Domsch
2004-11-01 22:03 ` Herbert Xu
2004-10-30 1:48 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101215944.GB17279@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).