From: "David S. Miller" <davem@davemloft.net>
To: Tommy Christensen <tommy.christensen@tpack.net>
Cc: herbert@gondor.apana.org.au, mingo@elte.hu, netdev@oss.sgi.com
Subject: Re: [NET] Move local_bh_disable back in dev_queue_xmit
Date: Wed, 3 Nov 2004 12:50:30 -0800 [thread overview]
Message-ID: <20041103125030.211d9833.davem@davemloft.net> (raw)
In-Reply-To: <4188EFD1.4050909@tpack.net>
On Wed, 03 Nov 2004 15:48:49 +0100
Tommy Christensen <tommy.christensen@tpack.net> wrote:
> Herbert Xu wrote:
> > Hi Ingo:
> >
> > Your recent fix to dev_queue_xmit moved the local_bh_disable to
> > include stuff like skb_linearize and skb_checksum_help. These
> > are potentially expensive operations. Since they don't need to
> > run with preempt off, we could simply move the local_bh_enable
> > up instead.
>
> No, this breaks the normal return path.
>
> How about this instead?
Yep, this one is better. Patch applied, thanks everyone.
next prev parent reply other threads:[~2004-11-03 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 22:54 [NET] Move local_bh_disable back in dev_queue_xmit Herbert Xu
2004-11-03 1:10 ` Ingo Molnar
2004-11-03 14:48 ` Tommy Christensen
2004-11-03 20:50 ` David S. Miller [this message]
2004-11-03 21:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041103125030.211d9833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mingo@elte.hu \
--cc=netdev@oss.sgi.com \
--cc=tommy.christensen@tpack.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).