From: Jon Mason <jdmason@us.ibm.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com, jgarzik@pobox.com
Subject: Re: [PATCH 2/3] r8169: Large Send enablement
Date: Fri, 5 Nov 2004 05:50:33 +0000 [thread overview]
Message-ID: <200411050550.33521.jdmason@us.ibm.com> (raw)
In-Reply-To: <20041104184529.GA2694@electric-eye.fr.zoreil.com>
On Thursday 04 November 2004 06:45 pm, Francois Romieu wrote:
> Jon Mason <jdmason@us.ibm.com> :
> > On Tuesday 02 November 2004 01:11 pm, Francois Romieu wrote:
> > [...]
> >
> > > - If rtl8169_open() fails [*] when the device was previously up, the
> > > driver could/should try to recover.
> >
> > I disagree. It should fail, complain loudly, and let the user try and
> > fix it (or return it to the previous state). The code provided below
> > will act like
>
> Mmmm... Actually both patches try to paper over the real issue: the driver
> should reserve the resources it needs for the change of mtu first.
Agreed. I did a quick look in the other drivers, and didn't find any drivers
that handle this possibility. Most of them ignore the fact. This sounds
like an open hole in all of the drivers.
next prev parent reply other threads:[~2004-11-05 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 18:03 [PATCH 2/3] r8169: Large Send enablement Jon Mason
2004-11-02 19:11 ` Francois Romieu
2004-11-04 0:16 ` Jon Mason
2004-11-04 18:45 ` Francois Romieu
2004-11-05 5:50 ` Jon Mason [this message]
2004-11-04 0:17 ` [PATCH] r8169: Large Send enablement, part 2 Jon Mason
2004-11-02 19:50 ` [PATCH 2/3] r8169: Large Send enablement Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411050550.33521.jdmason@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).