From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 PKT_SCHED]: Fix rcu_assign_pointer fallout, use it in the right place
Date: Fri, 5 Nov 2004 16:46:55 -0800 [thread overview]
Message-ID: <20041105164655.5d5639b8.davem@davemloft.net> (raw)
In-Reply-To: <418BF48A.5060707@trash.net>
On Fri, 05 Nov 2004 22:45:46 +0100
Patrick McHardy <kaber@trash.net> wrote:
> The patch "RCU: use rcu_assign_pointer()"
> http://linux.bkbits.net:8080/linux-2.6/diffs/net/sched/sch_api.c@1.39?nav=index.html|src/net/|src/net|src/net/sched|related/net/sched/sch_api.c|cset@1.2287
> changed a list_add_tail to list_add_tail_rcu in qdisc_create. It's
> dev->qdisc not dev->qdisc_list that is protected by RCU, this patch
> reverts that change. It also removes a misleading comment and replaces
> the smp_wmb in qdisc_create_dflt by rcu_assign_pointer in dev_activate
> to document more clearly what is protected.
Good catch Patrick, patch applied.
Thanks a lot.
prev parent reply other threads:[~2004-11-06 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 21:45 [PATCH 2.6 PKT_SCHED]: Fix rcu_assign_pointer fallout, use it in the right place Patrick McHardy
2004-11-06 0:46 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041105164655.5d5639b8.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).