From: Andrew Morton <akpm@osdl.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: jgarzik@pobox.com, jesse.brandeburg@intel.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] ixgb: fix ixgb_intr looping checks
Date: Mon, 8 Nov 2004 15:10:48 -0800 [thread overview]
Message-ID: <20041108151048.4bf605c1.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0411081446550.18540-100000@isotope.jf.intel.com>
Jesse Brandeburg <jesse.brandeburg@intel.com> wrote:
>
> This patch undoes a change that we believe will impact performance adversely,
> by creating possibly too long a delay between servicing completions.
Maybe. But now take a look at how much additional pointless work will be
done in the common case. For instance, every tx completion will incur a
call to ixgb_clean_rx_irq(), which then calls ixgb_alloc_rx_buffers().
There's quite a bit which can be optimised here.
next prev parent reply other threads:[~2004-11-08 23:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 20:45 [PATCH 2.6] ixgb: fix ixgb_intr looping checks Jesse Brandeburg
2004-11-02 20:50 ` Jesse Brandeburg
2004-11-05 7:31 ` Jeff Garzik
2004-11-08 22:50 ` Jesse Brandeburg
2004-11-08 23:10 ` Andrew Morton [this message]
2004-11-10 17:51 ` Jesse Brandeburg
2004-11-10 19:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041108151048.4bf605c1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).