* AX.25 cb lookup patch
@ 2004-11-09 3:36 Ralf Baechle
2004-11-10 6:05 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2004-11-09 3:36 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Ax AX.25 connection is identified only by it's source and destination,
not by the device it's routed through, so fix the connection block
lookup to ignore the device of a connection. This fixes dying connections
in case of an AX.25 routing flap.
Index: net/ax25/af_ax25.c
===================================================================
RCS file: /home/cvs/linux/net/ax25/af_ax25.c,v
retrieving revision 1.59
diff -u -r1.59 af_ax25.c
--- net/ax25/af_ax25.c 12 Oct 2004 01:45:52 -0000 1.59
+++ net/ax25/af_ax25.c 3 Nov 2004 03:23:53 -0000
@@ -207,16 +207,8 @@
continue;
if (s->ax25_dev == NULL)
continue;
- if (ax25cmp(&s->source_addr, src_addr) == 0 && ax25cmp(&s->dest_addr, dest_addr) == 0 && s->ax25_dev->dev == dev) {
- if (digi != NULL && digi->ndigi != 0) {
- if (s->digipeat == NULL)
- continue;
- if (ax25digicmp(s->digipeat, digi) != 0)
- continue;
- } else {
- if (s->digipeat != NULL && s->digipeat->ndigi != 0)
- continue;
- }
+ if (ax25cmp(&s->source_addr, src_addr) == 0 &&
+ ax25cmp(&s->dest_addr, dest_addr) == 0) {
ax25_cb_hold(s);
spin_unlock_bh(&ax25_list_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: AX.25 cb lookup patch
2004-11-09 3:36 AX.25 cb lookup patch Ralf Baechle
@ 2004-11-10 6:05 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-11-10 6:05 UTC (permalink / raw)
To: Ralf Baechle; +Cc: netdev
On Tue, 9 Nov 2004 04:36:18 +0100
Ralf Baechle <ralf@linux-mips.org> wrote:
> Ax AX.25 connection is identified only by it's source and destination,
> not by the device it's routed through, so fix the connection block
> lookup to ignore the device of a connection. This fixes dying connections
> in case of an AX.25 routing flap.
Applied, thanks Ralf.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-10 6:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-09 3:36 AX.25 cb lookup patch Ralf Baechle
2004-11-10 6:05 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).