From: Thomas Graf <tgraf@suug.ch>
To: "Catalin(ux aka Dino) BOIE" <util@deuroconsult.ro>
Cc: linux-net@vger.kernel.org, lartc@mailman.ds9a.nl, netdev@oss.sgi.com
Subject: Re: [PATCH] [TRY2] Use nfmark as a key in u32 classifier
Date: Tue, 9 Nov 2004 14:30:35 +0100 [thread overview]
Message-ID: <20041109133035.GH31969@postel.suug.ch> (raw)
In-Reply-To: <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro>
* Catalin(ux aka Dino) BOIE <Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro> 2004-11-09 14:27
> This is the try number two.
> What was changed:
> - Added selectable choice in Kconfig file (thanks Jamal!)
> - Don't abuse tc_u32_sel to not break backward compatibility (thanks
> Patrick!).
Your patchs looks fine except for missing dependcy on CONFIG_NETFILTER.
Either make CLS_U32_MARK dependant on it or #ifdef the references
to skb->nfmark.
It might be fair to tell you that this code is likely to be removed
again once we have the metadata match.
Cheers
next prev parent reply other threads:[~2004-11-09 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 12:27 [PATCH] [TRY2] Use nfmark as a key in u32 classifier Catalin(ux aka Dino) BOIE
2004-11-09 12:36 ` jamal
2004-11-09 13:00 ` Catalin(ux aka Dino) BOIE
2004-11-09 13:30 ` Thomas Graf [this message]
2004-11-09 13:46 ` Catalin(ux aka Dino) BOIE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041109133035.GH31969@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=lartc@mailman.ds9a.nl \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=util@deuroconsult.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).