From: "David S. Miller" <davem@davemloft.net>
To: Patrick McHardy <kaber@trash.net>
Cc: hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 PKT_SCHED]: Fix overflow on 64bit in times reported to userspace by tc actions
Date: Thu, 11 Nov 2004 15:03:14 -0800 [thread overview]
Message-ID: <20041111150314.576ce699.davem@davemloft.net> (raw)
In-Reply-To: <41908D1D.50405@trash.net>
On Tue, 09 Nov 2004 10:25:49 +0100
Patrick McHardy <kaber@trash.net> wrote:
> This patch fixes on overflow in tc actions times reported to
> userspace on 64 bit architectures. struct tcf_t only contains
> 32-bit timestamps, but they are initialized to jiffies. When
> jiffies is larger than 2^32-1 only the low 32 bit are saved,
> and the diff between jiffies and the current timestamp becomes
> very large. This happens immediately after boottime since jiffies
> is initialized to 2^32-300. It was invisible until now because
> only the lower 32bit were reported to userspace, but with the
> USER_HZ conversion the reported times start somewhere around
> 4294967s.
>
> This patch extends the timestamps to 64bit. It breaks userspace
> compatibility for actions, but considering that most of this is
> not even in iproute yet this should be acceptable.
I agree, and since Jamal also ACK'd it, I've applied
this patch.
Thanks.
next prev parent reply other threads:[~2004-11-11 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 9:25 [PATCH 2.6 PKT_SCHED]: Fix overflow on 64bit in times reported to userspace by tc actions Patrick McHardy
2004-11-11 23:03 ` David S. Miller [this message]
2004-11-21 17:47 ` jamal
2004-11-22 11:12 ` Patrick McHardy
2004-11-22 13:24 ` jamal
2004-11-22 19:40 ` Patrick McHardy
2004-11-23 13:39 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041111150314.576ce699.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).