From: Daniele Venzano <webvenza@libero.it>
To: Jeff Garzik <jgarzik@pobox.com>, Rusty Russell <rusty@rustcorp.com.au>
Cc: NetDev <netdev@oss.sgi.com>
Subject: [PATCH] convert sis900 to new style parameters
Date: Fri, 12 Nov 2004 23:07:10 +0100 [thread overview]
Message-ID: <20041112220710.GB29980@gateway.milesteg.arr> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]
The attached patch converts MODULE_PARM() calls in module_param() calls.
I've tested it and the expected files were created in sysfs.
For now all parameters are read-only. After some check I'll probably
change some of them to r/w.
The patch is against 2.6.9 and if no issues are raised, I propose it for
inclusion.
This patch is also available at http://teg.homeunix.org/sis900.html
--
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org
[-- Attachment #1.2: sis900-module-param.diff --]
[-- Type: text/plain, Size: 910 bytes --]
--- a/drivers/net/sis900.c 2004-11-12 16:26:50.000000000 +0100
+++ b/drivers/net/sis900.c 2004-11-12 16:33:20.000000000 +0100
@@ -48,6 +48,7 @@
*/
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/timer.h>
@@ -179,9 +180,9 @@
MODULE_DESCRIPTION("SiS 900 PCI Fast Ethernet driver");
MODULE_LICENSE("GPL");
-MODULE_PARM(multicast_filter_limit, "i");
-MODULE_PARM(max_interrupt_work, "i");
-MODULE_PARM(debug, "i");
+module_param(multicast_filter_limit, int, 0444);
+module_param(max_interrupt_work, int, 0444);
+module_param(debug, int, 0444);
MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of filtered multicast addresses");
MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled per interrupt");
MODULE_PARM_DESC(debug, "SiS 900/7016 debug level (2-4)");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-11-12 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 22:07 Daniele Venzano [this message]
2004-11-14 1:19 ` [PATCH] convert sis900 to new style parameters Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041112220710.GB29980@gateway.milesteg.arr \
--to=webvenza@libero.it \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).