* [patch] net/core/pktgen.c shouldn't include pci.h
@ 2004-11-13 14:53 Adrian Bunk
2004-11-14 7:18 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2004-11-13 14:53 UTC (permalink / raw)
To: Robert Olsson; +Cc: davem, netdev, linux-kernel
If rebuilding after touching pci.h in 2.6, net/core/pktgen.c is the only
file under net/ that gets rebuilt.
I searched and didn't find any reason why net/core/pktgen.c needs to
include pci.h .
I'm therefore suggesting the patch below (applies against both 2.4
and 2.6).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm5-full/net/core/pktgen.c.old 2004-11-13 14:37:43.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/net/core/pktgen.c 2004-11-13 14:40:07.000000000 +0100
@@ -69,7 +69,6 @@
#include <linux/ioport.h>
#include <linux/slab.h>
#include <linux/interrupt.h>
-#include <linux/pci.h>
#include <linux/delay.h>
#include <linux/init.h>
#include <linux/inet.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] net/core/pktgen.c shouldn't include pci.h
2004-11-13 14:53 [patch] net/core/pktgen.c shouldn't include pci.h Adrian Bunk
@ 2004-11-14 7:18 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-11-14 7:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: robert.olsson, netdev, linux-kernel
On Sat, 13 Nov 2004 15:53:51 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> If rebuilding after touching pci.h in 2.6, net/core/pktgen.c is the only
> file under net/ that gets rebuilt.
>
> I searched and didn't find any reason why net/core/pktgen.c needs to
> include pci.h .
>
> I'm therefore suggesting the patch below (applies against both 2.4
> and 2.6).
Yeah, that's pretty weird. Patch applied, thanks Adrian :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-14 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-13 14:53 [patch] net/core/pktgen.c shouldn't include pci.h Adrian Bunk
2004-11-14 7:18 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).