* [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni
@ 2004-11-14 10:38 Christoph Hellwig
2004-11-18 22:22 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-11-14 10:38 UTC (permalink / raw)
To: davem; +Cc: netdev
Some architectures can optimize local_softirq_pending much better than
softirq_pending(smp_processor_id()), and for all others the former is
just a macro expanding to the later.
Also this is the last use of softirq_pending() in common code, once this
is in we can soon kill the notation of beeing able to query other cpus
softirq pending count.
--- 1.174/net/core/dev.c 2004-11-10 01:12:00 +01:00
+++ edited/net/core/dev.c 2004-11-14 11:35:19 +01:00
@@ -1470,7 +1470,7 @@ int netif_rx_ni(struct sk_buff *skb)
preempt_disable();
err = netif_rx(skb);
- if (softirq_pending(smp_processor_id()))
+ if (local_softirq_pending())
do_softirq();
preempt_enable();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni
2004-11-14 10:38 [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni Christoph Hellwig
@ 2004-11-18 22:22 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-11-18 22:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: netdev
On Sun, 14 Nov 2004 11:38:46 +0100
Christoph Hellwig <hch@lst.de> wrote:
> Some architectures can optimize local_softirq_pending much better than
> softirq_pending(smp_processor_id()), and for all others the former is
> just a macro expanding to the later.
>
> Also this is the last use of softirq_pending() in common code, once this
> is in we can soon kill the notation of beeing able to query other cpus
> softirq pending count.
Queued for 2.6.11, thanks Christoph.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-18 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-14 10:38 [PATCH] use local_softirq_pending instead of softirq_pending in netif_rx_ni Christoph Hellwig
2004-11-18 22:22 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).