From: Christoph Hellwig <hch@infradead.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Mirko Lindner <demon@pro-linux.de>,
netdev@oss.sgi.com
Subject: Re: [PATCH] (5/25) sk98: elimnate nested macro.
Date: Tue, 16 Nov 2004 08:23:50 +0000 [thread overview]
Message-ID: <20041116082350.GB24321@infradead.org> (raw)
In-Reply-To: <20041115152208.6684c483@zqx3.pdx.osdl.net>
On Mon, Nov 15, 2004 at 03:22:08PM -0800, Stephen Hemminger wrote:
> Replace nested macros to handle defining 64bit constants with
> simpler macro. Would prefer to just remove it but it gets used in multiple
> OS common code.
I don't think the driver is complex enough for all that os-common mess.
If you look at the BSD sk driver it's about a third of the size of the
Linux driver because it doesn't have all this mess.
next prev parent reply other threads:[~2004-11-16 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041115150910.0f3b8498@zqx3.pdx.osdl.net>
2004-11-15 23:21 ` [PATCH] (2/25) sk98: handle device rename impact on /proc Stephen Hemminger
2004-11-15 23:21 ` [PATCH] (3/25) sk98: remove #define of net_device Stephen Hemminger
2004-11-15 23:22 ` [PATCH] (4/25) sk98: change #define to typedef Stephen Hemminger
2004-11-16 8:22 ` Christoph Hellwig
2004-11-15 23:22 ` [PATCH] (5/25) sk98: elimnate nested macro Stephen Hemminger
2004-11-16 8:23 ` Christoph Hellwig [this message]
2004-11-15 23:22 ` [PATCH] (6/25) sk98: get rid of #define's for C99 types Stephen Hemminger
2004-11-15 23:23 ` [PATCH] (7/25) sk98: remove unneeded include's Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116082350.GB24321@infradead.org \
--to=hch@infradead.org \
--cc=demon@pro-linux.de \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).