From: Chris Wright <chrisw@osdl.org>
To: James Morris <jmorris@redhat.com>
Cc: Chris Wright <chrisw@osdl.org>,
Ross Kendall Axe <ross.axe@blueyonder.co.uk>,
netdev@oss.sgi.com, Stephen Smalley <sds@epoch.ncsc.mil>,
lkml <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
Date: Thu, 18 Nov 2004 09:07:06 -0800 [thread overview]
Message-ID: <20041118090706.O2357@build.pdx.osdl.net> (raw)
In-Reply-To: <Xine.LNX.4.44.0411181158110.5096-100000@thoron.boston.redhat.com>; from jmorris@redhat.com on Thu, Nov 18, 2004 at 12:01:34PM -0500
* James Morris (jmorris@redhat.com) wrote:
> On Thu, 18 Nov 2004, Chris Wright wrote:
>
> > Why not make a unix_seq_sendmsg, which is a very small wrapper?
>
> Good idea, patch forthcoming.
>
> > Does the above stop the other issue? My laptop died, so I'm not able to
> > test ATM.
>
> No, it seems to be caused when addrlen in sendto() is non-zero, causing
> unix_find_other() to be called instead of unix_peer_get(), which is
> screwing up reference counts.
Right, but the snippet I posted guards against that I think. It forces
unix_peer_get() in dgram_sendmsg.
> As for MSG_EOR, apart from the generic socket code, nothing is being done.
> This would be a separate issue.
Yup, just noting the bits that looked broken to me.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-11-18 17:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 18:13 [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET Ross Kendall Axe
2004-11-15 13:31 ` Stephen Smalley
2004-11-16 8:41 ` Chris Wright
2004-11-17 21:29 ` Ross Kendall Axe
2004-11-18 0:09 ` Ross Kendall Axe
2004-11-18 3:42 ` James Morris
2004-11-18 4:25 ` James Morris
2004-11-18 6:07 ` Chris Wright
2004-11-18 7:25 ` Ross Kendall Axe
2004-11-18 7:59 ` James Morris
2004-11-18 8:27 ` James Morris
2004-11-18 16:44 ` Chris Wright
2004-11-18 17:01 ` James Morris
2004-11-18 17:07 ` Chris Wright [this message]
2004-11-18 17:11 ` James Morris
2004-11-18 17:25 ` James Morris
2004-11-18 16:58 ` Alan Cox
2004-11-18 22:34 ` David S. Miller
2004-11-19 3:23 ` Ross Kendall Axe
2004-11-19 7:19 ` Chris Wright
2004-11-19 9:40 ` Ross Kendall Axe
2004-11-19 13:05 ` Arnaldo Carvalho de Melo
2004-11-19 13:16 ` Arnaldo Carvalho de Melo
2004-11-18 16:49 ` Alan Cox
2004-11-18 18:40 ` James Morris
2004-11-18 23:39 ` Alan Cox
2004-11-19 3:12 ` James Morris
2004-11-19 7:01 ` Chris Wright
2004-11-19 7:12 ` James Morris
2004-11-19 7:28 ` Chris Wright
2004-11-19 11:39 ` Alan Cox
2004-11-19 16:24 ` James Morris
2004-11-20 7:11 ` David S. Miller
2004-11-18 16:45 ` Alan Cox
2004-11-18 18:28 ` James Morris
2004-11-18 18:34 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041118090706.O2357@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=ross.axe@blueyonder.co.uk \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).