From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wright Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET Date: Thu, 18 Nov 2004 09:07:06 -0800 Message-ID: <20041118090706.O2357@build.pdx.osdl.net> References: <20041118084449.Z14339@build.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Wright , Ross Kendall Axe , netdev@oss.sgi.com, Stephen Smalley , lkml , "David S. Miller" Return-path: To: James Morris Content-Disposition: inline In-Reply-To: ; from jmorris@redhat.com on Thu, Nov 18, 2004 at 12:01:34PM -0500 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org * James Morris (jmorris@redhat.com) wrote: > On Thu, 18 Nov 2004, Chris Wright wrote: > > > Why not make a unix_seq_sendmsg, which is a very small wrapper? > > Good idea, patch forthcoming. > > > Does the above stop the other issue? My laptop died, so I'm not able to > > test ATM. > > No, it seems to be caused when addrlen in sendto() is non-zero, causing > unix_find_other() to be called instead of unix_peer_get(), which is > screwing up reference counts. Right, but the snippet I posted guards against that I think. It forces unix_peer_get() in dgram_sendmsg. > As for MSG_EOR, apart from the generic socket code, nothing is being done. > This would be a separate issue. Yup, just noting the bits that looked broken to me. thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net