* [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success
@ 2004-11-18 19:04 John W. Linville
2004-11-18 22:14 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2004-11-18 19:04 UTC (permalink / raw)
To: linux-kernel, linux-net, netdev; +Cc: greearb, vlan
The VLAN net driver needs to return 0 from vlan_dev_change_mtu()
on success.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
The proper sucessful return code for the change_mtu() method is zero.
For some reason, vlan_dev_change_mtu() is returning the new mtu value
instead.
net/8021q/vlan_dev.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- 1.23/net/8021q/vlan_dev.c 2004-10-28 19:23:09 -04:00
+++ 1.24/net/8021q/vlan_dev.c 2004-11-18 11:12:36 -05:00
@@ -527,7 +527,7 @@
dev->mtu = new_mtu;
- return new_mtu;
+ return 0;
}
int vlan_dev_set_ingress_priority(char *dev_name, __u32 skb_prio, short vlan_prio)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success
2004-11-18 19:04 [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success John W. Linville
@ 2004-11-18 22:14 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-11-18 22:14 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-kernel, linux-net, netdev, greearb, vlan
On Thu, 18 Nov 2004 14:04:36 -0500
"John W. Linville" <linville@tuxdriver.com> wrote:
> The VLAN net driver needs to return 0 from vlan_dev_change_mtu()
> on success.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Both 2.4.x and 2.6.x variants applied, thanks John.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-18 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-18 19:04 [patch netdev-2.6] vlan_dev: return 0 on vlan_dev_change_mtu success John W. Linville
2004-11-18 22:14 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).