From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Cc: cgoos@syskonnect.de, mlindner@syskonnect.de, jgarzik@pobox.com
Subject: [patch netdev-2.6] skge: return 0 on success from SkGeChangeMtu
Date: Thu, 18 Nov 2004 14:14:35 -0500 [thread overview]
Message-ID: <20041118141435.B16007@tuxdriver.com> (raw)
The SKGE driver needs to return 0 from SkGeChangeMtu() on success.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
The proper sucessful return code for the change_mtu() method is zero.
For some reason, SkGeChangeMtu() is returning the new mtu value
instead. The comments would seem to indicate past problems, but the
current correct behaviour is clear.
drivers/net/sk98lin/skge.c | 14 +-------------
1 files changed, 1 insertion(+), 13 deletions(-)
--- 1.54/drivers/net/sk98lin/skge.c 2004-11-03 17:31:05 -05:00
+++ 1.55/drivers/net/sk98lin/skge.c 2004-11-18 11:12:36 -05:00
@@ -2849,19 +2849,7 @@
SkEventDispatcher(pAC, pAC->IoBase);
spin_unlock_irqrestore(&pAC->SlowPathLock, Flags);
- /*
- ** While testing this driver with latest kernel 2.5 (2.5.70), it
- ** seems as if upper layers have a problem to handle a successful
- ** return value of '0'. If such a zero is returned, the complete
- ** system hangs for several minutes (!), which is in acceptable.
- **
- ** Currently it is not clear, what the exact reason for this problem
- ** is. The implemented workaround for 2.5 is to return the desired
- ** new MTU size if all needed changes for the new MTU size where
- ** performed. In kernels 2.2 and 2.4, a zero value is returned,
- ** which indicates the successful change of the mtu-size.
- */
- return NewMtu;
+ return 0;
} /* SkGeChangeMtu */
reply other threads:[~2004-11-18 19:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041118141435.B16007@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=cgoos@syskonnect.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).