From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
netdev@oss.sgi.com
Cc: greearb@candelatech.com, jgarzik@pobox.com
Subject: [patch netdev-2.4] vlan_dev: return 0 on vlan_dev_change_mtu success
Date: Thu, 18 Nov 2004 14:27:49 -0500 [thread overview]
Message-ID: <20041118142749.C16007@tuxdriver.com> (raw)
The VLAN net driver needs to return 0 from vlan_dev_change_mtu()
on success.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
The proper sucessful return code for the change_mtu() method is zero.
For some reason, vlan_dev_change_mtu() is returning the new mtu value
instead.
net/8021q/vlan_dev.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- 1.14/net/8021q/vlan_dev.c 2004-07-05 19:34:03 -04:00
+++ edited/net/8021q/vlan_dev.c 2004-11-18 14:26:29 -05:00
@@ -528,7 +528,7 @@
dev->mtu = new_mtu;
- return new_mtu;
+ return 0;
}
int vlan_dev_set_ingress_priority(char *dev_name, __u32 skb_prio, short vlan_prio)
reply other threads:[~2004-11-18 19:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041118142749.C16007@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=greearb@candelatech.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).