netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch netdev-2.4] vlan_dev: return 0 on vlan_dev_change_mtu success
@ 2004-11-18 19:27 John W. Linville
  0 siblings, 0 replies; only message in thread
From: John W. Linville @ 2004-11-18 19:27 UTC (permalink / raw)
  To: linux-kernel, linux-net, netdev; +Cc: greearb, jgarzik

The VLAN net driver needs to return 0 from vlan_dev_change_mtu()
on success.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
The proper sucessful return code for the change_mtu() method is zero.
For some reason, vlan_dev_change_mtu() is returning the new mtu value
instead.

 net/8021q/vlan_dev.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

--- 1.14/net/8021q/vlan_dev.c	2004-07-05 19:34:03 -04:00
+++ edited/net/8021q/vlan_dev.c	2004-11-18 14:26:29 -05:00
@@ -528,7 +528,7 @@
 
 	dev->mtu = new_mtu;
 
-	return new_mtu;
+	return 0;
 }
 
 int vlan_dev_set_ingress_priority(char *dev_name, __u32 skb_prio, short vlan_prio)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-11-18 19:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-18 19:27 [patch netdev-2.4] vlan_dev: return 0 on vlan_dev_change_mtu success John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).