From: Chris Wright <chrisw@osdl.org>
To: James Morris <jmorris@redhat.com>
Cc: Mitchell Blank Jr <mitch@sfgoth.com>,
netdev@oss.sgi.com, Chris Wright <chrisw@osdl.org>,
Stephen Smalley <sds@epoch.ncsc.mil>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] fix missing security_*() check in net/compat.c
Date: Tue, 30 Nov 2004 09:06:34 -0800 [thread overview]
Message-ID: <20041130090634.Y2357@build.pdx.osdl.net> (raw)
In-Reply-To: <Xine.LNX.4.44.0411301117010.12330-100000@thoron.boston.redhat.com>; from jmorris@redhat.com on Tue, Nov 30, 2004 at 11:17:41AM -0500
* James Morris (jmorris@redhat.com) wrote:
> On Tue, 30 Nov 2004, Mitchell Blank Jr wrote:
>
> > While looking at the SCM passing code in net/core/scm.c I noticed that there's
> > a 32-bit compat implementation of scm_detach_fds()'s called
> > scm_detach_fds_compat() living in net/compat.c. While these two functions
> > are mostly the same the latter does not include the call to the
> > security_file_receive() hook which is almost certainly a bug.
> >
> > My sparc64 test box isn't set up currently so this is not tested. Someone
> > running a 64-bit kernel with CONFIG_COMPAT should verify that this at
> > least compiles.
> >
> > Signed-off-by: Mitchell Blank Jr <mitch@sfgoth.com>
>
> Looks correct to me.
>
> Signed-off-by: James Morris <jmorris@redhat.com>
Yup, looks fine.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2004-11-30 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 14:54 [PATCH] fix missing security_*() check in net/compat.c Mitchell Blank Jr
2004-11-30 16:17 ` James Morris
2004-11-30 17:06 ` Chris Wright [this message]
2004-11-30 21:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130090634.Y2357@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=davem@davemloft.net \
--cc=jmorris@redhat.com \
--cc=mitch@sfgoth.com \
--cc=netdev@oss.sgi.com \
--cc=sds@epoch.ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).