From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [PATCH] fix missing security_*() check in net/compat.c Date: Tue, 30 Nov 2004 13:40:53 -0800 Message-ID: <20041130134053.268d4134.davem@davemloft.net> References: <20041130145444.GF63669@gaz.sfgoth.com> <20041130090634.Y2357@build.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jmorris@redhat.com, mitch@sfgoth.com, netdev@oss.sgi.com, chrisw@osdl.org, sds@epoch.ncsc.mil Return-path: To: Chris Wright In-Reply-To: <20041130090634.Y2357@build.pdx.osdl.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, 30 Nov 2004 09:06:34 -0800 Chris Wright wrote: > * James Morris (jmorris@redhat.com) wrote: > > On Tue, 30 Nov 2004, Mitchell Blank Jr wrote: > > > > > While looking at the SCM passing code in net/core/scm.c I noticed that there's > > > a 32-bit compat implementation of scm_detach_fds()'s called > > > scm_detach_fds_compat() living in net/compat.c. While these two functions > > > are mostly the same the latter does not include the call to the > > > security_file_receive() hook which is almost certainly a bug. > > > > > > My sparc64 test box isn't set up currently so this is not tested. Someone > > > running a 64-bit kernel with CONFIG_COMPAT should verify that this at > > > least compiles. > > > > > > Signed-off-by: Mitchell Blank Jr > > > > Looks correct to me. > > > > Signed-off-by: James Morris > > Yup, looks fine. Applied, thanks everyone.