From: Mitchell Blank Jr <mitch@sfgoth.com>
To: netdev@oss.sgi.com
Subject: [PATCH] fix missing security_*() check in net/compat.c
Date: Tue, 30 Nov 2004 06:54:44 -0800 [thread overview]
Message-ID: <20041130145444.GF63669@gaz.sfgoth.com> (raw)
While looking at the SCM passing code in net/core/scm.c I noticed that there's
a 32-bit compat implementation of scm_detach_fds()'s called
scm_detach_fds_compat() living in net/compat.c. While these two functions
are mostly the same the latter does not include the call to the
security_file_receive() hook which is almost certainly a bug.
My sparc64 test box isn't set up currently so this is not tested. Someone
running a 64-bit kernel with CONFIG_COMPAT should verify that this at
least compiles.
Signed-off-by: Mitchell Blank Jr <mitch@sfgoth.com>
-Mitch
--- linux-2.6.10-rc2-bk9-VIRGIN/net/compat.c 2004-10-18 14:54:37.000000000 -0700
+++ linux-2.6.10-rc2-bk9/net/compat.c 2004-11-30 06:40:52.156434868 -0800
@@ -22,6 +22,7 @@
#include <linux/filter.h>
#include <linux/compat.h>
#include <linux/netfilter_ipv4/ip_tables.h>
+#include <linux/security.h>
#include <net/scm.h>
#include <net/sock.h>
@@ -264,6 +265,9 @@
for (i = 0, cmfptr = (int __user *) CMSG_COMPAT_DATA(cm); i < fdmax; i++, cmfptr++) {
int new_fd;
+ err = security_file_receive(fp[i]);
+ if (err)
+ break;
err = get_unused_fd();
if (err < 0)
break;
next reply other threads:[~2004-11-30 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 14:54 Mitchell Blank Jr [this message]
2004-11-30 16:17 ` [PATCH] fix missing security_*() check in net/compat.c James Morris
2004-11-30 17:06 ` Chris Wright
2004-11-30 21:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041130145444.GF63669@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).