From: Thomas Graf <tgraf@suug.ch>
To: jamal <hadi@cyberus.ca>
Cc: Michal Ludvig <mludvig@suse.cz>, Andrew Morton <akpm@osdl.org>,
Stephen Hemminger <shemminger@osdl.org>,
netdev@oss.sgi.com, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] rtnetlink & address family problem
Date: Tue, 7 Dec 2004 13:49:22 +0100 [thread overview]
Message-ID: <20041207124922.GA1371@postel.suug.ch> (raw)
In-Reply-To: <1102386461.1093.26.camel@jzny.localdomain>
* jamal <1102386461.1093.26.camel@jzny.localdomain> 2004-12-06 21:27
> On Mon, 2004-12-06 at 09:02, Thomas Graf wrote:
>
> > Your patch would fix this issue but might break various things. The
> > actual problem is that iproute2 doesn't check the family in its filter.
> > It blindly assumes that the kernel only returns addresses of the kind it
> > has requested. I can understand if you think the current behaviour
> > is wrong but we shouldn't change it in the middle of a stable tree.
>
> Why would it be wrong? The PF_UNSPEC is there for a purpose.
I don't think it is wrong myself but I understand if someone does. If
one sends a GETADDR request for PF_INET6 one might expect to either
receive all ipv6 addresses or none and to only receive all addresess
of any type if PF_UNSPEC was specified.
> If user space decides it wants to flush ipv4 addresses blindly that user
> spaces fault. The patch you attached seems legit. did you verify it?
Not yet, it probably has to be applied to iproute.c as well. I'll have
a look at it and do some testing.
next prev parent reply other threads:[~2004-12-07 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-03 17:43 [PATCH] rtnetlink & address family problem Michal Ludvig
2004-12-06 11:40 ` jamal
2004-12-06 14:02 ` Thomas Graf
2004-12-07 2:27 ` jamal
2004-12-07 12:49 ` Thomas Graf [this message]
2004-12-07 13:02 ` jamal
2004-12-07 13:17 ` Thomas Graf
2004-12-07 13:20 ` jamal
2004-12-07 14:10 ` Thomas Graf
2004-12-07 16:55 ` Thomas Graf
2004-12-07 17:52 ` Thomas Graf
2004-12-07 19:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207124922.GA1371@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=akpm@osdl.org \
--cc=hadi@cyberus.ca \
--cc=jack@suse.cz \
--cc=mludvig@suse.cz \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).