From: Daniele Venzano <webvenza@libero.it>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Daniele Venzano <webvenza@libero.it>, NetDev <netdev@oss.sgi.com>
Subject: Re: [PATCH 1/5] sis900 printk and stack usage audit
Date: Sun, 12 Dec 2004 09:15:09 +0100 [thread overview]
Message-ID: <20041212081509.GA3084@picchio.gall.it> (raw)
In-Reply-To: <41BB452D.5040507@pobox.com>
On Sat, Dec 11, 2004 at 02:06:21PM -0500, Jeff Garzik wrote:
> >@@ -390,13 +390,6 @@
> > u8 revision;
> > char *card_name = card_names[pci_id->driver_data];
> >
> >-/* when built into the kernel, we only print version if device is found */
> >-#ifndef MODULE
> >- static int printed_version;
> >- if (!printed_version++)
> >- printk(version);
> >-#endif
> >-
> > /* setup various bits in PCI command register */
> > ret = pci_enable_device(pci_dev);
> > if(ret) return ret;
>
> There is no double-printing. One is #ifndef MODULE, one is #ifdef MODULE.
>
> Did you read the comment included in the code you deleted???
My bad, dropped.
--
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org
next prev parent reply other threads:[~2004-12-12 8:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-08 10:47 [PATCH 0/5] sis900 printk and stack usage audit Daniele Venzano
2004-12-08 11:01 ` [PATCH 1/5] " Daniele Venzano
2004-12-11 19:04 ` Jeff Garzik
2004-12-11 19:06 ` Jeff Garzik
2004-12-12 8:15 ` Daniele Venzano [this message]
2004-12-08 11:04 ` [PATCH 2/5] " Daniele Venzano
2004-12-11 19:09 ` Jeff Garzik
2004-12-12 8:19 ` Daniele Venzano
2004-12-08 11:06 ` [PATCH 3/5] " Daniele Venzano
2004-12-11 19:09 ` Jeff Garzik
2004-12-08 11:08 ` [PATCH 4/5] " Daniele Venzano
2004-12-11 19:11 ` Jeff Garzik
2004-12-12 8:23 ` Daniele Venzano
2004-12-08 11:10 ` [PATCH 5/5] " Daniele Venzano
2004-12-11 19:11 ` Jeff Garzik
2004-12-12 8:27 ` Daniele Venzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041212081509.GA3084@picchio.gall.it \
--to=webvenza@libero.it \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).